Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refine gRPC error code #232

Merged
merged 1 commit into from
Mar 23, 2023
Merged

chore: refine gRPC error code #232

merged 1 commit into from
Mar 23, 2023

Conversation

will-2012
Copy link
Collaborator

@will-2012 will-2012 commented Mar 22, 2023

Description

Refine the gRPC error code, which is more user-friendly.

Rationale

N/A.

Example

N/A.

Changes

Notable changes:
N/A.

@will-2012 will-2012 marked this pull request as draft March 22, 2023 08:11
@will-2012 will-2012 added the wip Working in process label Mar 22, 2023
@will-2012 will-2012 force-pushed the chore-refineerrorcode branch 2 times, most recently from c0ca23e to 7d1dc0b Compare March 22, 2023 08:17
@will-2012 will-2012 marked this pull request as ready for review March 22, 2023 08:25
@will-2012 will-2012 requested review from sysvm and joeylichang March 22, 2023 08:25
@will-2012 will-2012 added r4r Ready for review and removed wip Working in process labels Mar 22, 2023
@will-2012 will-2012 changed the title chore: refine error code chore: refine gRPC error code Mar 22, 2023
@will-2012 will-2012 force-pushed the chore-refineerrorcode branch from 7d1dc0b to 527f205 Compare March 22, 2023 11:42
@joeylichang
Copy link
Contributor

LGTM

Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@will-2012 will-2012 merged commit f693c65 into develop Mar 23, 2023
@joeylichang joeylichang deleted the chore-refineerrorcode branch March 27, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants