Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix payment apis nil pointer error #264

Merged
merged 1 commit into from
Mar 30, 2023
Merged

Conversation

BarryTong65
Copy link
Contributor

@BarryTong65 BarryTong65 commented Mar 30, 2023

Description

fix payment api nil pointer error

Rationale

nil streamRecord will cause nil pointer error

Changes

Notable changes:

  • add extra if statement to avoid nil pointer error

@BarryTong65 BarryTong65 added the wip Working in process label Mar 30, 2023
@BarryTong65 BarryTong65 requested a review from annielz March 30, 2023 04:15
@BarryTong65 BarryTong65 added r4r Ready for review and removed wip Working in process labels Mar 30, 2023
@joeylichang
Copy link
Contributor

LGTM

@BarryTong65 BarryTong65 merged commit e9bb229 into develop Mar 30, 2023
@joeylichang joeylichang deleted the fix-paymentapi branch March 30, 2023 04:52
joeylichang added a commit that referenced this pull request Apr 6, 2023
* feat: add e2e test to workflow (#263)

* feat: e2e test is added to action

* chore: change workflow naming

* fix: fix payment apis nil pointer error (#264)

* fix: fix sa iam type to access s3 (#265)

Co-authored-by: DylanYong <dylan.y@nodereal.io>

* feat: update buckets/objects order (#270)

feat: update buckets/objects order

* fix: upgrade juno version with property length fix (#273)

* docs: update license (#282)

Co-authored-by: Keefe Liu <keefe.l@binance.com>

* fix: merge error

* docs: add changelog for v0.1.0

---------

Co-authored-by: BarryTong65 <122767193+BarryTong65@users.noreply.github.com>
Co-authored-by: will-2012 <117156346+will-2012@users.noreply.github.com>
Co-authored-by: VM <112189277+sysvm@users.noreply.github.com>
Co-authored-by: DylanYong <dylan.y@nodereal.io>
Co-authored-by: krish-nr <krish.z@nodereal.io>
Co-authored-by: krish-z <122767080+krish-nr@users.noreply.github.com>
Co-authored-by: constwz <122766871+constwz@users.noreply.github.com>
Co-authored-by: dylanhuang <j75689@gmail.com>
Co-authored-by: will-2012 <will.w@nodereal.io>
Co-authored-by: constwz <changbohao30@gmail.com>
Co-authored-by: BarryTong65 <barrytong.work@gmail.com>
Co-authored-by: KeefeL <90749943+KeefeL@users.noreply.github.com>
Co-authored-by: Keefe Liu <keefe.l@binance.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants