Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rcmgr leak for downloader service #277

Merged
merged 3 commits into from
Apr 6, 2023
Merged

fix: rcmgr leak for downloader service #277

merged 3 commits into from
Apr 6, 2023

Conversation

joeylichang
Copy link
Contributor

Description

  1. Replicate background context by context with cancel, in defer will call cancel to close the connection.
  2. Fixed the same problem in the put and sync object.
  3. Polished the rcmgr related code and logs of the downloader and challenge.

Rationale

The client terminates requests during download, and memory statistics in the downloader service resource manager are not released. Because the gateway did not close the connection, the downloader service still did not release resources.

Example

N/A

Changes

Notable changes:

  • gateway put/get object add context cancel
  • gate sync object add context cancel

@joeylichang joeylichang added the r4r Ready for review label Apr 5, 2023
Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joeylichang joeylichang merged commit 60aa273 into develop Apr 6, 2023
@joeylichang joeylichang deleted the fix-rcmgr branch April 6, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants