feat: support dns for p2p node #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
reviewed
Apr 12, 2023
pkg/p2p/node_config.go
Outdated
| if net.ParseIP(host) == nil { | ||
| hosts, err := net.LookupHost(host) | ||
| if err != nil { | ||
| err = fmt.Errorf("failed to parser bootstrap '%s' domain", boot) |
sysvm
reviewed
Apr 12, 2023
pkg/p2p/node_config.go
Outdated
| return peersID, addrs, err | ||
| } | ||
| if len(hosts) == 0 { | ||
| err = fmt.Errorf("failed to parser bootstrap '%s' domain, the empty ip list", boot) |
sysvm
reviewed
Apr 12, 2023
pkg/p2p/node_config.go
Outdated
| break | ||
| } | ||
| if net.ParseIP(host) == nil { | ||
| err = fmt.Errorf("failed to parser bootstrap '%s' domain, no usable ip", boot) |
will-2012
approved these changes
Apr 12, 2023
BarryTong65
pushed a commit
that referenced
this pull request
Apr 14, 2023
* feat: support dns for p2p node * fix: ut error * fix: only support ipv4 * fix: cr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support DNS for p2p bootstrap node
Rationale
Use for k8s ALB and NLB
Example
N/A
Changes
Notable changes:
N/A