-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: block sycner add txhash when export events & juno version update #338
Conversation
if err != nil { | ||
log.Errorf("failed to ExportEvents: %s", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why delete log?
@@ -3,6 +3,7 @@ package blocksyncer | |||
import ( | |||
"context" | |||
"encoding/json" | |||
"fmt" | |||
|
|||
"github.com/bnb-chain/greenfield-storage-provider/pkg/log" | |||
"github.com/bnb-chain/greenfield-storage-provider/pkg/metrics" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg group as follows: std lib, third-party, inner lib
50a826a
to
53bbce0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
block syncer add txhash info when export events. Also update juno version for stop serving function and include SP module and GC function.
Rationale
Example
N/A
Changes
Notable changes: