Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: block sycner add txhash when export events & juno version update #338

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

krish-nr
Copy link
Contributor

@krish-nr krish-nr commented Apr 19, 2023

Description

block syncer add txhash info when export events. Also update juno version for stop serving function and include SP module and GC function.

Rationale

  1. We need txhash info when seal an object. Block syncer add this context.
  2. Chain side add the new feat of stop serving, we implement that in juno and here with juno version updated
  3. block syncer persist SP metadata by handling SP events in juno
  4. adapt chain side changes

Example

N/A

Changes

Notable changes:

  • add txhash when export events
  • adapt indexer interface change

@krish-nr krish-nr added the r4r Ready for review label Apr 19, 2023
@krish-nr krish-nr changed the title feat: block sycner add txhash when export events feat: block sycner add txhash when export events & juno version update Apr 20, 2023
if err != nil {
log.Errorf("failed to ExportEvents: %s", err)
Copy link
Collaborator

@sysvm sysvm Apr 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why delete log?

@@ -3,6 +3,7 @@ package blocksyncer
import (
"context"
"encoding/json"
"fmt"

"github.com/bnb-chain/greenfield-storage-provider/pkg/log"
"github.com/bnb-chain/greenfield-storage-provider/pkg/metrics"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg group as follows: std lib, third-party, inner lib

@krish-nr krish-nr force-pushed the feat-blocksycner-addevents branch from 50a826a to 53bbce0 Compare April 20, 2023 07:01
Copy link
Collaborator

@sysvm sysvm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krish-nr krish-nr merged commit ee44add into develop Apr 20, 2023
@krish-nr krish-nr deleted the feat-blocksycner-addevents branch April 24, 2023 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants