Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: universal endpoint attachment #345

Merged
merged 2 commits into from
Apr 20, 2023
Merged

fix: universal endpoint attachment #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09247c5
fix: universal endpoint download attachment
annielz Apr 20, 2023
5255a76
fix: content disposition header position
annielz Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions model/const.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,10 @@ const (
ContentTypeJSONHeaderValue = "application/json"
// ContentTypeXMLHeaderValue is used to indicate xml
ContentTypeXMLHeaderValue = "application/xml"
//ContentDispositionHeader is used to indicate the media disposition of the resource
ContentDispositionHeader = "Content-Disposition"
//ContentDispositionAttachmentValue is used to indicate attachment
ContentDispositionAttachmentValue = "attachment"

// SignAlgorithm uses secp256k1 with the ECDSA algorithm
SignAlgorithm = "ECDSA-secp256k1"
Expand Down
1 change: 1 addition & 0 deletions service/gateway/object_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@ func (gateway *Gateway) getObjectByUniversalEndpointHandler(w http.ResponseWrite
errDescription = makeErrorDescription(err)
return
}
w.Header().Set(model.ContentDispositionHeader, model.ContentDispositionAttachmentValue)
for {
resp, err := stream.Recv()
if err == io.EOF {
Expand Down