-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add gc worker #408
Merged
Merged
feat: add gc worker #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
will-2012
force-pushed
the
feat-gc-worker
branch
3 times, most recently
from
May 9, 2023 13:38
612381c
to
1ac71e3
Compare
joeylichang
approved these changes
May 10, 2023
sysvm
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
joeylichang
added a commit
that referenced
this pull request
May 15, 2023
* feat: sp services add pprof * feat:block syncer add read concurrency support * fix: rename pprof var name * fix:debug log * fix: fix the content of sp readme * feat: add universal endpoint view option (#383) * feat: add universal endpoint view option fix: imports * fix: add space before comments * fix: put header in right place (#385) * feat: signer async send sealObject tx * fix: simplify gnfd client signature test case * fix: return function when get nonce on chain failed * fix: annotation * fix: cross region netroek opt * feat: implement stop serving on testnet (#336) * feat: localup shell adds generate sp.info and db.info function (#398) * feat: localup shell adds generate sp.info and db.info function * fix: fix reset db function name * feat: support full-memory replicate task (#410) * feat: add gc worker (#408) * feat: bsdb switch (#402) * feat: update metadata db config and startDBSwitchListener * feat: update e2e config * fix: rename bsdbflag and update config/config_template.toml * feat:add upload download add bandwidth limit * feat: list objects pagination & folder path (#404) * feat: add pagination for list objects * fix: define constant queries & update func name * fix: update filter for listobjects when delimiter is empty * fix: refine query name * fix: nil config.SQLDBConfig (#413) * feat: add get object meta and get bucket meta apis (#412) * feat: add get object and get bucket with payment apis feat: modify long name feat: sort import correctly fix: typos fix: typo * fix: address comments, change path params to query params fix: typo * feat: add unit tests for new apis * fix: rename services and comments according to comments fix: import position * fix:BandwidthLimit config * fix:bandwidth config * feat: adapt greenfield v0.47 (#406) * fix: upgrade greenfield version to v0.2.0 (#415) Co-authored-by: VM <arimas@foxmail.com> * feat: add dual db warm up support for blocksyncer (#401) * feat: add dual db warm up support for blocksyncer * feat: add stop main service logic * feat: update chain version to v0.47 and some adapts * fix: upgrade e2e ci greenfield version to v0.2.0 (#418) Co-authored-by: VM <arimas@foxmail.com> * docs: add v0.2.0 changelog (#417) * docs: add v0.2.0 changelog * fix: add blocksycner dual db feature in changelog * docs: add localup shell feature in changelog --------- Co-authored-by: actioncli <joeycli0919@qq.com> Co-authored-by: krish-nr <krish.z@nodereal.io> Co-authored-by: VM <arimas@foxmail.com> * feat: replace github.com/gogo/protobuf with github.com/cosmos/gogoproto (#422) --------- Co-authored-by: VM <arimas@foxmail.com> Co-authored-by: constwz <changbohao30@gmail.com> Co-authored-by: Annie <108039750+annielz@users.noreply.github.com> Co-authored-by: j75689 <j75689@gmail.com> Co-authored-by: constwz <122766871+constwz@users.noreply.github.com> Co-authored-by: forcodedancing <just.haha.it@gmail.com> Co-authored-by: VM <112189277+sysvm@users.noreply.github.com> Co-authored-by: will-2012 <117156346+will-2012@users.noreply.github.com> Co-authored-by: Barry <122767193+BarryTong65@users.noreply.github.com> Co-authored-by: Chris Li <jingjunLi@users.noreply.github.com> Co-authored-by: krish-z <122767080+krish-nr@users.noreply.github.com> Co-authored-by: actioncli <joeycli0919@qq.com> Co-authored-by: krish-nr <krish.z@nodereal.io> Co-authored-by: yutianwu <wzxingbupt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add GC worker.
Rationale
Add a GC worker inside the manager module, periodically obtain the deleted object list from the metadata, delete their specific data in the piece store, and free the storage space.
The GC worker will be refactored according to the design of the task scheduler and task node in the future.
Example
N/A.
Changes
Notable changes: