feat:add upload download add bandwidth limit #411
Conversation
constwz
force-pushed
the
feat-bandwidth-limit
branch
from
2aeb8d7 to
ed9edae
Compare
config/config.go
Outdated
| @@ -44,6 +44,7 @@ type StorageProviderConfig struct { | |||
| RateLimiter *localhttp.RateLimiterConfig | |||
| DiscontinueCfg *stopserving.DiscontinueConfig | |||
| MetadataCfg *metadata.MetadataConfig | |||
| BandwidthLimiter *localhttp.BandWidthLimiterConfig | |||
There was a problem hiding this comment.
Rename BandWidthLimiterConfig to BandwidthLimiterConfig .
| @@ -208,6 +210,10 @@ var DefaultRateLimiterConfig = &localhttp.RateLimiterConfig{ | |||
| }, | |||
| } | |||
|
|
|||
| var DefaultBandwidthLimiterConfig = &localhttp.BandWidthLimiterConfig{ | |||
| Enable: false, | |||
There was a problem hiding this comment.
Maybe you need to update the default configuration synchronously at config/config_template.toml.
pkg/middleware/http/tokenBucket.go
Outdated
| type BandWidthLimiterConfig struct { | ||
| Enable bool | ||
| R rate.Limit | ||
| B int |
There was a problem hiding this comment.
Add more commentaries to explain the config meaning.
This naming convention is a bit vague for the name that the user needs to configure, and the user may not understand it.
service/gateway/object_handler.go
Outdated
| // If it is limited, it will block | ||
| if localHttp.BandWidthLimit != nil { | ||
| if err := localHttp.BandWidthLimit.Limiter.Wait(ctx); err != nil { | ||
| log.Errorw("failed to Wait bandwidth limiter", "err", err) |
There was a problem hiding this comment.
Refine Wait to wait, err to error in log.
service/gateway/object_handler.go
Outdated
| @@ -223,6 +229,12 @@ func (gateway *Gateway) putObjectHandler(w http.ResponseWriter, r *http.Request) | |||
| return | |||
| } | |||
| if readN > 0 { | |||
| // If it is limited, it will block | |||
| if localHttp.BandWidthLimit != nil { | |||
| if err := localHttp.BandWidthLimit.Limiter.Wait(ctx); err != nil { | |||
There was a problem hiding this comment.
I don't understand how to calculate the actual bandwidth of the service?
There was a problem hiding this comment.
The first version of the implementation was simple and limited to whether data could be read from the network
constwz
force-pushed
the
feat-bandwidth-limit
branch
from
ed9edae to
56ac4f7
Compare
constwz
force-pushed
the
feat-bandwidth-limit
branch
from
abea273 to
abe9cc1
Compare
constwz
force-pushed
the
feat-bandwidth-limit
branch
from
abe9cc1 to
476c356
Compare
Description
Upload and download with broadband stream implementation
Rationale
Protect the sp service
Example
Limit the upload and download speed
Changes
Notable changes: