fix group member key collision issues

bnb-chain · Aug 9, 2023 · 9f0b70a · 9f0b70a
1 parent e207200
commit 9f0b70a
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/x/permission/types/keys.go b/x/permission/types/keys.go
@@ -82,13 +82,22 @@ func GetPolicyByIDKey(policyID math.Uint) []byte {
 }
 
 func GroupMembersPrefix(groupID math.Uint) []byte {
-	return append(GroupMemberPrefix, groupID.Bytes()...)
+	return append(GroupMemberPrefix, LengthPrefix(groupID.Bytes())...)
 }
 
 func GetGroupMemberKey(groupID math.Uint, member sdk.AccAddress) []byte {
-	return append(GroupMemberPrefix, append(groupID.Bytes(), member.Bytes()...)...)
+	return append(GroupMemberPrefix, append(LengthPrefix(groupID.Bytes()), member.Bytes()...)...)
 }
 
 func GetGroupMemberByIDKey(memberID math.Uint) []byte {
 	return append(GroupMemberByIDPrefix, memberID.Bytes()...)
 }
+
+func LengthPrefix(bz []byte) []byte {
+	bzLen := len(bz)
+	if bzLen == 0 {
+		return bz
+	}
+
+	return append([]byte{byte(bzLen)}, bz...)
+}