feat: add max buckets per account into storage module params #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fynnss
force-pushed
the
fynn/add_bucket_limit_params
branch
from
500878e to
743be80
Compare
fynnss
force-pushed
the
fynn/add_bucket_limit_params
branch
from
743be80 to
40d984e
Compare
joeylichang
approved these changes
Mar 20, 2023
|
LGTM |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To prevent an excessive number of bucket creations from affecting domain name redirection performance or other performacce problem, it's important to place a limit on the number of buckets that each user can create.
Rationale
NA
Example
Changes
Notable changes: