Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refine payment module #129

Merged
merged 2 commits into from
Mar 23, 2023
Merged

chore: refine payment module #129

merged 2 commits into from
Mar 23, 2023

Conversation

owen-reorg
Copy link
Contributor

@owen-reorg owen-reorg commented Mar 21, 2023 •
edited
Loading

Description

Refine the codes of the payment module according to the quality standard.

Rationale

NA

Example

NA

Changes

Notable changes:

  • Add more comments
  • Extract and reuse the function to derive payment account address

@owen-reorg owen-reorg added the r4r label Mar 21, 2023
@unclezoro
Copy link
Collaborator

LGTM

fynnss
fynnss approved these changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@fynnss fynnss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@unclezoro unclezoro merged commit cc32130 into develop Mar 23, 2023
This was referenced Mar 24, 2023
Merged
Merged
@unclezoro unclezoro deleted the quality/payment branch April 18, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fynnss fynnss fynnss approved these changes

@unclezoro unclezoro unclezoro approved these changes

@j75689 j75689 Awaiting requested review from j75689

Assignees
No one assigned
Labels
r4r
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@owen-reorg @unclezoro @fynnss