feat: allow mirror bucket/object/group using name #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
May 19, 2023
x/storage/client/cli/tx.go
Outdated
| @@ -756,11 +756,13 @@ $ %s tx delete-policy 3 | |||
|
|
|||
| func CmdMirrorBucket() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "mirror-bucket [bucket-id]", | |||
| Use: "mirror-bucket [bucket-id] [bucket-name]", | |||
There was a problem hiding this comment.
I think it is a bad parameter setting, for example if I provide bucket-id, I dont need to provide bucket-name. I can not set the bucket name only for the current implementation.
There was a problem hiding this comment.
Yes. I changed it to use flags for both bucket-id and bucket-name.
unclezoro
reviewed
May 19, 2023
unclezoro
reviewed
May 19, 2023
unclezoro
reviewed
May 19, 2023
forcodedancing
force-pushed
the
feat/mirror_msgs
branch
from
90fd751
to
a418577
Compare
fynnss
reviewed
May 19, 2023
| if msg.Id.GT(sdk.NewUint(0)) { | ||
| objectInfo, found = k.Keeper.GetObjectInfoById(ctx, msg.Id) | ||
| } else { | ||
| objectInfo, found = k.Keeper.GetObjectInfo(ctx, msg.BucketName, msg.ObjectName) |
There was a problem hiding this comment.
It's a bit confused. Any checks will added to make sure the ID and name correspond to each other? Or if the name is specified, the id must be zero, Or if the ID is greater than 0, the name must be empty.
There was a problem hiding this comment.
Yes. The check had been added to the ValidateBasic functions.
forcodedancing
force-pushed
the
feat/mirror_msgs
branch
from
a418577
to
52ec318
Compare
unclezoro
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will allowing mirroring bucket/object/group by using
idorname.Rationale
By using
name, we can package some messages in a single tx, e.g.,CreateBucketMirrorBucketin one tx.Example
NA
Changes
Notable changes: