feat: add extra field to group #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao001
force-pushed
the
add_group_description
branch
from
e00b3b4
to
c5cf23e
Compare
unclezoro
reviewed
May 23, 2023
unclezoro
reviewed
May 23, 2023
fynnss
reviewed
May 24, 2023
| @@ -855,6 +855,7 @@ func NewMsgCreateGroup(creator sdk.AccAddress, groupName string, membersAcc []sd | |||
| Creator: creator.String(), | |||
| GroupName: groupName, | |||
| Members: members, | |||
| Extra: extra, | |||
There was a problem hiding this comment.
I think we should limit the length of the extra field.
e2e/tests/permission_test.go
Outdated
| //s.SendTxBlock(owner, msgDeleteGroup) | ||
| // | ||
| //// policy is GC | ||
| //_, err = s.Client.QueryPolicyById(ctx, &storagetypes.QueryPolicyByIdRequest{PolicyId: policyID.String()}) |
There was a problem hiding this comment.
was for testing, removed,
x/storage/client/cli/tx.go
Outdated
| @@ -516,12 +516,13 @@ func CmdDiscontinueObject() *cobra.Command { | |||
|
|
|||
| func CmdCreateGroup() *cobra.Command { | |||
| cmd := &cobra.Command{ | |||
| Use: "create-group [group-name] [member-list]", | |||
| Use: "create-group [group-name] [member-list [extra]", | |||
There was a problem hiding this comment.
The extra is optional, so I suggest you use a flag for it.
unclezoro
reviewed
May 24, 2023
alexgao001
force-pushed
the
add_group_description
branch
from
f8a54a4
to
fd48f31
Compare
unclezoro
reviewed
May 25, 2023
x/storage/types/message.go
Outdated
| TypeMsgMirrorGroup = "mirror_group" | ||
|
|
||
| MaxGroupExtraInfoLimit = 256 |
There was a problem hiding this comment.
seems a bit short, please try 512.
unclezoro
approved these changes
May 25, 2023
forcodedancing
pushed a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr adds a extra field when creating a group. user can define the content of any format but type of string for it.
Rationale
This enriches the GROUP Usage scenario
Example
NA
Changes
Notable changes: