feat: implement cross-chain mechanism between op and greenfield #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
alexgao001
reviewed
Aug 11, 2023
| @@ -734,7 +734,7 @@ func (app *App) initModules(ctx sdk.Context) { | |||
|
|
|||
| func (app *App) initCrossChain() { | |||
| app.CrossChainKeeper.SetSrcChainID(sdk.ChainID(app.appConfig.CrossChain.SrcChainId)) | |||
| app.CrossChainKeeper.SetDestChainID(sdk.ChainID(app.appConfig.CrossChain.DestBscChainId)) | |||
| app.CrossChainKeeper.SetDestBscChainID(sdk.ChainID(app.appConfig.CrossChain.DestBscChainId)) | |||
There was a problem hiding this comment.
is DestOpChainID needed?
There was a problem hiding this comment.
we need a hardfork to register the DestOpChainID
| CreateRawIBCPackageWithFee(ctx sdk.Context, chainID sdk.ChainID, channelID sdk.ChannelID, packageType sdk.CrossChainPackageType, | ||
| packageLoad []byte, relayerFee *big.Int, ackRelayerFee *big.Int, | ||
| ) (uint64, error) | ||
|
|
||
| IsDestChainSupported(chainID sdk.ChainID) bool | ||
|
|
||
| RegisterChannel(name string, id sdk.ChannelID, app sdk.CrossChainApplication) error |
There was a problem hiding this comment.
do we need to specify the dest chain id ?
There was a problem hiding this comment.
no, the app is bind to the channel, all the dest chains use the same app
unclezoro
approved these changes
Aug 11, 2023
alexgao001
approved these changes
Aug 14, 2023
This was referenced Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr implements the cross-chain mechanism between op and greenfield.
Rationale
Implement cross-chain mechanism between op and greenfield.
Example
n/a
Changes
Notable changes: