Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate bls key and proof before submitting proposal #419

Merged
merged 4 commits into from
Aug 15, 2023

Conversation

alexgao001
Copy link
Collaborator

Description

Previous the proposal can be created while bls key and proof are not valid. this pr adds the validation before submitting the proposal

Rationale

would waste BNB if invalid proposal allowed to be created.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@unclezoro unclezoro added this pull request to the merge queue Aug 15, 2023
Merged via the queue into bnb-chain:develop with commit 02b1db7 Aug 15, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants