chore: improve the validations of messages #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
force-pushed
the
tx_validation_review
branch
from
bb67d03
to
8de6dd9
Compare
forcodedancing
changed the title
forcodedancing
force-pushed
the
tx_validation_review
branch
from
f9cd8a4
to
5ea3d25
Compare
forcodedancing
changed the title
forcodedancing
force-pushed
the
tx_validation_review
branch
from
6df9702
to
8ddb3b4
Compare
fynnss
reviewed
Sep 19, 2023
| //} | ||
| //if !containsCreateObject && s.LimitSize != nil { | ||
| // return ErrInvalidStatement.Wrap("The LimitSize option can only be used with CreateObject actions at the bucket level. .") | ||
| //} | ||
| for _, r := range s.Resources { |
There was a problem hiding this comment.
Shall we move the GRN check to ValidateRuntime ? I think yes.
There was a problem hiding this comment.
Why we need to move the GRN check to ValidateRuntime?
It does not change between these upgrades. Keep it in ValidateBasic will be useful for CLI.
There was a problem hiding this comment.
Because it may be adjusted in the future.
j75689
reviewed
Oct 17, 2023
forcodedancing
force-pushed
the
tx_validation_review
branch
from
49a2303
to
92bcef0
Compare
yutianwu
approved these changes
Oct 17, 2023
j75689
approved these changes
Oct 17, 2023
unclezoro
reviewed
Oct 18, 2023
unclezoro
approved these changes
Oct 18, 2023
This was referenced Nov 2, 2023
This was referenced Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve the basic validation of messages.
Rationale
Chore
Example
NA
Changes
Notable changes: