feat: add cross chain txs for storage resources #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
force-pushed
the
add_mirror_storage
branch
2 times, most recently
from
e89abe9 to
708a13c
Compare
fynnss
reviewed
Feb 16, 2023
fynnss
reviewed
Feb 16, 2023
fynnss
reviewed
Feb 16, 2023
yutianwu
force-pushed
the
add_mirror_storage
branch
2 times, most recently
from
78f343f to
96c505d
Compare
yutianwu
changed the title
yutianwu
force-pushed
the
add_mirror_storage
branch
2 times, most recently
from
2d82402 to
7c6c861
Compare
unclezoro
reviewed
Feb 23, 2023
unclezoro
reviewed
Feb 23, 2023
unclezoro
reviewed
Feb 23, 2023
unclezoro
requested changes
Feb 23, 2023
yutianwu
force-pushed
the
add_mirror_storage
branch
4 times, most recently
from
3a07607 to
9bcf681
Compare
unclezoro
reviewed
Mar 3, 2023
unclezoro
reviewed
Mar 3, 2023
fynnss
reviewed
Mar 4, 2023
yutianwu
force-pushed
the
add_mirror_storage
branch
2 times, most recently
from
e5e2638 to
76f4a65
Compare
unclezoro
approved these changes
Mar 6, 2023
|
Please fulfill the content in the PR template, with no deletion for the Rational and Examples part. |
yutianwu
force-pushed
the
add_mirror_storage
branch
3 times, most recently
from
0d77020 to
9c3ded9
Compare
yutianwu
force-pushed
the
add_mirror_storage
branch
from
efe2fd5 to
e8bba7a
Compare
fynnss
reviewed
Mar 17, 2023
This was referenced Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request will add transactions for mirroring resources from Greenfield to BSC, as well as operations for creating and deleting Buckets and Groups.
New messages will be added:
MirrorBucketMirrorObjectMirrorGroupNew cross-chain apps will be implemented:
BucketApp: bucket app will handle the cross-chain functions likecreate bucket,delete bucket,mirror bucketObjectApp: object app will handle the cross-chain functions likedelete object,mirror objectGroupApp: group app will handle the cross-chain functions likecreate group,delete group,mirror groupRationale
To implement the cross-chain functions for the storage module.
Example
Mirror bucket:
Mirror object:
Mirror group:
Changes
Notable changes: