Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: sync inspect mpt tool from bsc #52

Merged
merged 8 commits into from
Jan 29, 2024

Conversation

will-2012
Copy link
Contributor

@will-2012 will-2012 commented Jan 22, 2024

Description

Cherry-pick inspect mpt tool from bsc.

bnb-chain/bsc#2082
bnb-chain/bsc#2142

Rationale

N/A.

Example

N/A.

Changes

Notable changes:

  • CMD: add inspect mpt tool.

cmd/geth/dbcmd.go Outdated Show resolved Hide resolved
@owen-reorg owen-reorg requested review from bendanzhentan and removed request for andyzhang2023 January 23, 2024 02:28
bnoieh
bnoieh previously approved these changes Jan 23, 2024
bendanzhentan
bendanzhentan previously approved these changes Jan 23, 2024
trie/inspect_trie.go Outdated Show resolved Hide resolved
@will-2012 will-2012 dismissed stale reviews from bendanzhentan and bnoieh via 7ff7f3d January 23, 2024 09:11
Copy link

@RenRick RenRick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/rlp"
"github.com/olekukonko/tablewriter"

Copy link
Contributor

@sysvm sysvm Jan 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the blank line and resort?

@owen-reorg owen-reorg merged commit 371bc44 into bnb-chain:develop Jan 29, 2024
1 check passed
andyzhang2023 pushed a commit to andyzhang2023/op-geth that referenced this pull request Mar 4, 2024
Co-authored-by: Fynn <zcheng1004@gmail.com>
Co-authored-by: will@2012 <xibaow2020@qq.com>
andyzhang2023 pushed a commit to andyzhang2023/op-geth that referenced this pull request Apr 30, 2024
Co-authored-by: Fynn <zcheng1004@gmail.com>
Co-authored-by: will@2012 <xibaow2020@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants