Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot find parent block during livesync #111

Merged
merged 9 commits into from
Aug 20, 2024
Merged

fix: cannot find parent block during livesync #111

merged 9 commits into from
Aug 20, 2024

Conversation

forcodedancing
Copy link
Collaborator

@forcodedancing forcodedancing commented Aug 15, 2024 •
edited
Loading

Description

  • Fix cannot find parent during livesync of BSC.
  • Fix a dead loop issue in snapshot method (error is not handled previously).

Rationale

During live sync of BSC, the executor will try to find the parent from the database, which may not have been committed yet.

image

Example

image image image

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

Potential Impacts

  • add potential impacts for other components here
  • ...

@unclezoro unclezoro changed the base branch from main to develop August 20, 2024 05:59
@unclezoro unclezoro added this pull request to the merge queue Aug 20, 2024
Merged via the queue into bnb-chain:develop with commit cdd7cea Aug 20, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pythonberg1997 pythonberg1997 pythonberg1997 left review comments

@unclezoro unclezoro unclezoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@forcodedancing @unclezoro @pythonberg1997