Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sidecars missing issue and empty validators election info issue #119

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

pythonberg1997
Copy link
Contributor

Description

This pr is to fix 2 issues for bsc

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • write sidecars to file in log_transactions
  • let get_top_validators_by_voting_power return empty vector rather than None

Potential Impacts

  • add potential impacts for other components here
  • ...

@unclezoro unclezoro added this pull request to the merge queue Aug 26, 2024
Merged via the queue into bnb-chain:develop with commit e059925 Aug 26, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants