-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support importing blocks without merkle calculation #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Aug 28, 2024
unclezoro
reviewed
Aug 28, 2024
unclezoro
reviewed
Aug 30, 2024
j75689
force-pushed
the
feat/skip_merkle
branch
from
September 9, 2024 06:50
99f2a78
to
4ac0926
Compare
unclezoro
approved these changes
Sep 10, 2024
pythonberg1997
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
support importing blocks without merkle calculation mode
Rationale
Add a flag
--optimize.skip-state-root-validation
to disable state root calculation during block importing. This can be useful if the state root calculation is taking too long.However, be cautious when using this mode, as the accuracy of node data (PlainState) will no longer be strongly guaranteed.
Example
--optimize.skip-state-root-validation
flag(Optional) 2. Clear Trie/Hashed Account/Storage table to save database cost.
Changes
Notable changes:
Potential Impacts