feat: add support of block sidecars for bsc #45
Conversation
pythonberg1997
force-pushed
the
roshan/parlia
branch
6 times, most recently
from
24c036b to
250248f
Compare
| @@ -59,6 +59,7 @@ impl TryFrom<alloy_rpc_types::Block> for Block { | |||
| withdrawals: block.withdrawals.map(Into::into), | |||
| // todo(onbjerg): we don't know if this is added to rpc yet, so for now we leave it as | |||
| // empty. | |||
| sidecars: None, // TODO(roshan) | |||
There was a problem hiding this comment.
what is the TODO for here?
| @@ -289,8 +289,12 @@ impl PendingBlockEnv { | |||
| requests_root, | |||
| }; | |||
|
|
|||
| // TODO: add sidecars | |||
There was a problem hiding this comment.
Will we fix this todo?
| @@ -297,6 +306,11 @@ impl<DB: Database, D: BodyDownloader> Stage<DB> for BodyStage<D> { | |||
| withdrawals_cursor.delete_current()?; | |||
| } | |||
|
|
|||
| // Delete the sidecars entry if any | |||
There was a problem hiding this comment.
By the way, for unwind, did we unwind snapshots ?
There was a problem hiding this comment.
I think it's unnecessary. The saved snapshots are always behind current height. So we will always get correct snapshot. And unwinding snapshots is somehow difficult to do.
| @@ -12,16 +20,49 @@ use reth_stages_api::{ | |||
| #[non_exhaustive] | |||
| pub struct FinishStage; | |||
|
|
|||
| impl FinishStage { | |||
| /// prune sidecars older than `BLOCKS_KEPT` blocks | |||
| pub fn prune_sidecars<DB: Database>( | |||
There was a problem hiding this comment.
Why we put prune here? It's kind of wired - for other pruning (header, body ...), they do not execute here.
| @@ -35,6 +35,7 @@ mod metrics; | |||
| mod provider; | |||
|
|
|||
| pub use provider::{DatabaseProvider, DatabaseProviderRO, DatabaseProviderRW}; | |||
| use reth_storage_api::SidecarsProvider; | |||
There was a problem hiding this comment.
How about put the import along with other provides in line 5-9?
| }; | ||
| use reth_prune_types::{PruneCheckpoint, PruneLimiter, PruneModes, PruneSegment}; | ||
| use reth_stages_types::{StageCheckpoint, StageId}; | ||
| use reth_storage_api::SidecarsProvider; |
There was a problem hiding this comment.
How about put the import along with others?
crates/rpc/rpc/src/eth/cache/mod.rs
Outdated
| @@ -85,6 +90,7 @@ impl EthStateCache { | |||
| provider, | |||
| full_block_cache: BlockLruCache::new(max_blocks, "blocks"), | |||
| receipts_cache: ReceiptsLruCache::new(max_receipts, "receipts"), | |||
| sidecars_cache: SidecarsLruCache::new(max_receipts, "sidecars"), | |||
There was a problem hiding this comment.
Changed to max_blocks. I think we could reuse max_blocks to avoid a new param as there is 1 sidecars in 1 block.
| let start_prune = if current_block > 1_000_000 { current_block - 1_000_000 } else { 0 }; | ||
|
|
||
| let block_range = start_prune..current_block; | ||
| let mut limiter = PruneLimiter::default().set_time_limit(Duration::from_secs(3600)); |
There was a problem hiding this comment.
so the blob share the same database with plainstate, hashstate? This seems unacceptable.
crates/storage/db/src/tables/mod.rs
Outdated
| @@ -414,6 +414,9 @@ tables! { | |||
|
|
|||
| /// Stores the parlia snapshot data by block hash. | |||
| table ParliaSnapshot<Key = BlockHash, Value = Snapshot>; | |||
|
|
|||
| /// Stores block sidecars, indexed by block number. | |||
| table BlockSidecars<Key = BlockNumber, Value = BlobSidecars>; | |||
There was a problem hiding this comment.
I think this is not we expected, blob storage size is huge, we can not store it in a same database with other kind of state, it will cause huge state explosion
pythonberg1997
force-pushed
the
roshan/parlia
branch
from
250248f to
ee9614f
Compare
This reverts commit 00259fa.
This reverts commit 00259fa.
This reverts commit 00259fa.
Description
This pr is to add support of block sidecars for bsc
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
sidecarsfield toBlockandSealedBlockPotential Impacts