fix: check header timestamp in parlia task #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
changed the title
j75689
changed the title
j75689
force-pushed
the
fix/parlia_task_engine
branch
from
42c7a03 to
3bf3d5f
Compare
unclezoro
reviewed
Jun 27, 2024
crates/bsc/consensus/src/task.rs
Outdated
| // difference between the latest header number and the best header number | ||
| // the timestamp of latest header should be bigger than the predicted timestamp and | ||
| // less than the current timestamp. | ||
| let predicted_timestamp = best_header.timestamp + |
There was a problem hiding this comment.
shouldn't we compare to the latest persisted header, because it is trustworthy, but the best_header here is not trustworthy.
unclezoro
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add header timestamp check to protect fake blocks from the future.
Rationale
predict timestampis the trusted header(read from chain) timestamp plus the block interval times the difference between the latest header number and the trusted header number.the timestamp of latest header should be bigger than the predicted timestamp and less than the current timestamp.
Example
n/a
Changes
Notable changes:
Potential Impacts