go vet issues #163
Comments
|
This PR could solve it. #167 |
asdfsx
pushed a commit
to asdfsx/tss-lib
that referenced
this issue
Jul 22, 2023
asdfsx
added a commit
to asdfsx/tss-lib
that referenced
this issue
Jul 22, 2023
ackratos
pushed a commit
that referenced
this issue
Sep 20, 2023
yycen
pushed a commit
that referenced
this issue
Apr 18, 2024
* use *common.SignatureData instead of common.SignatureData to fix issue #163 * upgrade dependencies version * check the threshold and size of vs is equal * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi there. I am using go vet in my repo. I get an error in the case of getting signature data at the final round of signing.
assignment copies lock value to data: github.com/binance-chain/tss-lib/common.SignatureData contains google.golang.org/protobuf/internal/impl.MessageState contains sync.MutexAlso if you use your codes, you will get the same error in
https://github.com/bnb-chain/tss-lib/blob/30c5ee412a0ef9096ae37f67d6e0d5adcfdd551e/ecdsa/resharing/local_party_test.go#L209ecdsa/resharing/local_party_test.go:209:20: copylocks: assignment copies lock value to signData: github.com/binance-chain/tss-lib/common.SignatureData contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex (govet)The text was updated successfully, but these errors were encountered: