fix R and S may not be 32 bytes #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omershlo
reviewed
Mar 24, 2021
ecdsa/signing/finalize.go
Outdated
|
|
||
| func fillTo32BytesInPlace(src []byte) []byte { | ||
| oriLen := len(src) | ||
| if oriLen < 32 { |
There was a problem hiding this comment.
really minor : I think it would have been nicer to accept the wanted length as another input parameter to the function.
Besides that I would also rename the function to padToLengthBytesInPlace
There was a problem hiding this comment.
padToLengthBytesInPlace +1
omershlo
previously approved these changes
Mar 24, 2021
FitzLu
previously approved these changes
Mar 25, 2021
FitzLu
approved these changes
Apr 1, 2021
omershlo
approved these changes
Apr 1, 2021
ackratos
added a commit
that referenced
this pull request
Apr 2, 2021
* fix R and S may not be 32 bytes * refactor according to review comments (cherry picked from commit 49366aa) # Conflicts: # ecdsa/signing/finalize.go # ecdsa/signing/local_party_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The R and S might not be less than 32 bytes, if we return such R and S and the client code concatenates these two bytes together, the signature would not be 64 bytes. Such signature would fail for blockchains (for example Ethereum) that check the signature length: https://github.com/ethereum/go-ethereum/blob/master/crypto/secp256k1/secp256.go#L169-L171