Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/hd cherry pick #195

Merged
merged 6 commits into from
Sep 9, 2022
Merged

Conversation

plopezlpz
Copy link
Contributor

Child key derivation PR to master

yycen and others added 4 commits August 20, 2022 16:17
* Cherrypick child_key_derivation from SwingbyProtocol
https://github.com/SwingbyProtocol/tss-lib/pull/6/files#diff-e663957d1112b8c89bb7a782fe1cebe0d5e4d84a17861ae5af5cc0b59d1dbf56

* Add serialization to child key derivation
add test case from github.com/btcsuite/hdkeychain

* Making ec as parameter in key_derivation_util

* Add version string to extendedkey, to comply with BIP32
yycen
yycen previously approved these changes Sep 1, 2022
Fix test using FillBytes
@plopezlpz
Copy link
Contributor Author

@yycen thanks for reviewing, I've removed the use of *big.Int#FillBytes from the test since it is not available in go 1.13, so tests should be passing now.

@yycen yycen merged commit cbfa6cf into bnb-chain:master Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants