This repository has been archived by the owner on Jun 19, 2023. It is now read-only.
Scrolling #7
Closed
Scrolling #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Scrolling is controlled by a new parameter to RevealCodeFocus and is off
by default, to avoid any possible compatibility issues, although it
would probably be more user-friendly in the long run to default to on.
(Using an options object would probably be also be better than a boolean
parameter.)
The implementation pulls "classList.add('focus')" into a helper function
and adds tracking of offset of the focused lines of code.
bnjmnt4n
pushed a commit
that referenced
this pull request
Jul 31, 2016
Add support for scrolling to focused code.
|
Closed via 50aafa8. |
|
Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement automatically scrolling to focused code, as described in issue #6.