Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor websocket endpoints and move websocket state to dynamodb #34

Merged
merged 13 commits into from
Apr 28, 2024
Merged

Refactor websocket endpoints and move websocket state to dynamodb #34

merged 13 commits into from
Apr 28, 2024

Conversation

Hy0tic
Copy link
Contributor

@Hy0tic Hy0tic commented Apr 26, 2024 •
edited
Loading

Changes:

  • refactor websocket endpoint (roomUser -> userJoin and userDisconnect)
  • use DynamoDB to store websocket state
  • notif for user joining should be on client side
  • alert user if they get disconnected
  • add tofu plan and tofu apply workflow

Todo:

@Hy0tic Hy0tic changed the title Refactor websocket Refactor websocket endpoints and move websocket state to dynamodb Apr 27, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Hy0tic Hy0tic marked this pull request as ready for review April 28, 2024 04:47
@Hy0tic Hy0tic merged commit 30ea8ed into main Apr 28, 2024
5 checks passed
@Hy0tic Hy0tic deleted the refactor-websocket-endpoint branch April 28, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hy0tic