Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pancho/UI fix #7

Closed
wants to merge 17 commits into from
Closed

Pancho/UI fix #7

wants to merge 17 commits into from

Conversation

Hy0tic
Copy link
Contributor

@Hy0tic Hy0tic commented Apr 6, 2024 •
edited
Loading

Changes:

  • rounded container
  • center the tab text on join/host room form
  • changed theme to blue
  • up down arrow adjust volume
  • remove alert for validation on index page
  • clicking on video full screen instead of pause/play
  • socket io retry connection if it gets disconnected

Todo:

  • add shadow
  • ui layout (room info goes below chat and user list is at the bottom of page)
  • each user should have their own blue box
  • add glow effect when click on host and join button
  • refactor to not use alert()

image

Froidland and others added 15 commits April 6, 2024 04:40
@Froidland
round container
388730e
@Froidland
change ui color, increase gap between inputs, make the button an actu…
b9859b5 
…al button (yes...), split room info data into components
@Hy0tic
update icon
e448e1a
@Hy0tic
update food list
2000457
@Hy0tic
remove alert for username and room field validation
c5564d5
@Hy0tic
up down arrow key adjust volume
32601a4
@Hy0tic
Merge branch 'main' of https://github.com/bnlabs/Mello into pancho/ui…
5782a10 
…-fix
@Hy0tic
merge duplicate css selector
2f3b906
@Hy0tic
clicking on video player will fullscreen instead of pause/play, remov…
d5b8108 
…e chat border
@Hy0tic
add glowing effect to button when clicked
b2bda1a
@Hy0tic
Merge branch 'pancho/ui-fix' of https://github.com/bnlabs/mello into …
f66c647 
…pancho/ui-fix
@Hy0tic
erge branch 'main' of https://github.com/bnlabs/mello into
96177a8 
pancho/ui-fix
@Hy0tic
socket io connection retry if is disconnected
329aca5
@Froidland
add shadow to main menu
80c9a2b
@Froidland
extract user list into component and change style
170083c
@Hy0tic Hy0tic linked an issue Apr 9, 2024 that may be closed by this pull request
refactor ui #11
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Froidland Froidland closed this Apr 9, 2024
@Froidland Froidland deleted the pancho/ui-fix branch April 9, 2024 06:19
@Froidland Froidland mentioned this pull request Apr 9, 2024
Merged
12 tasks
@Hy0tic Hy0tic removed a link to an issue Apr 20, 2024
refactor ui #11
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hy0tic @Froidland