Fixed response ready signal. It was emitted multiple times.

Added X-Client-Name and X-Client-Version headers.

StellarQtSDK.pri

@@ -4,6 +4,10 @@ DEFINES += STELLAR_QT_REPLY_TIMEOUT=30000
 
 DEFINES *= ED25519_NO_SEED
 
+DEFINES += STELLAR_QT_SDK_CLIENT_NAME=\"\\\"qtcpp-stellar-sdk\\\"\"
+DEFINES += STELLAR_QT_SDK_CLIENT_VERSION=\"\\\"0.1.8\\\"\"
+
+
 QT *= core network
 CONFIG *= c++11
 

src/federation/federationserver.cpp

@@ -81,7 +81,7 @@ FederationServer::FederationServer(QString serverUri, QString domain) {
 FederationServer *FederationServer::createForDomain(QString domain) {
 
     if(s_cachedFederationServers){
-        FederationServer * cached = s_cachedFederationServers->value(domain,0);
+        FederationServer * cached = s_cachedFederationServers->value(domain,nullptr);
         if(cached)
             return cached;
     }

src/responses/page.cpp

@@ -86,7 +86,10 @@ PageBase *PageBase::getNextPage(){
         return nullptr;
     }
     QNetworkAccessManager* manager = this->m_reply->manager();
-    QNetworkReply * reply = manager->get(QNetworkRequest(this->getLinks().getNext().getHref()));
+    QNetworkRequest request(this->getLinks().getNext().getHref());
+    request.setRawHeader("X-Client-Name", STELLAR_QT_SDK_CLIENT_NAME);
+    request.setRawHeader("X-Client-Version", STELLAR_QT_SDK_CLIENT_VERSION);
+    QNetworkReply * reply = manager->get(request);
     this->loadFromReply(reply);
     return this;//we reuse same object
 }

src/responses/response.cpp

@@ -163,6 +163,9 @@ void Response::reconnectStreamDelayed()
     QNetworkRequest request(m_reply->request());
     if(!m_lastID.isEmpty())
         request.setRawHeader("Last-Event-ID",m_lastID);
+    request.setRawHeader("X-Client-Name", STELLAR_QT_SDK_CLIENT_NAME);
+    request.setRawHeader("X-Client-Version", STELLAR_QT_SDK_CLIENT_VERSION);
+
     QNetworkReply * reply = manager->get(request);
     loadFromReply(reply);
 }
@@ -204,7 +207,7 @@ bool Response::preprocessResponse(QNetworkReply *response)
     m_rateLimitLimit  =response->rawHeader("X-Ratelimit-Limit").toInt();
     m_rateLimitRemaining =response->rawHeader("X-Ratelimit-Remaining").toInt();
     m_rateLimitReset =response->rawHeader("X-Ratelimit-Reset").toInt();
-
+    emit rateLimitChanged();
     // Too Many Requests
     if (errorCode == 429) {
         int retryAfter = response->rawHeader("Retry-After").toInt();

src/responses/response.h

@@ -32,14 +32,14 @@ inline QList<T> convert(QVariantList source)
 class Response : public QObject
 {
     Q_OBJECT
-    Q_PROPERTY(int rateLimitLimit READ getRateLimitLimit NOTIFY ready)
-    Q_PROPERTY(int rateLimitRemaining READ getRateLimitRemaining NOTIFY ready)
-    Q_PROPERTY(int rateLimitReset READ getRateLimitReset NOTIFY ready)
-    Q_PROPERTY(QString type MEMBER m_type NOTIFY ready)
-    Q_PROPERTY(QString title MEMBER m_title NOTIFY ready)
-    Q_PROPERTY(int status MEMBER m_status NOTIFY ready)
-    Q_PROPERTY(QString instance MEMBER m_instance NOTIFY ready)
-    Q_PROPERTY(QString detail MEMBER m_detail NOTIFY ready)
+    Q_PROPERTY(int rateLimitLimit READ getRateLimitLimit NOTIFY rateLimitChanged)
+    Q_PROPERTY(int rateLimitRemaining READ getRateLimitRemaining NOTIFY rateLimitChanged)
+    Q_PROPERTY(int rateLimitReset READ getRateLimitReset NOTIFY rateLimitChanged)
+    Q_PROPERTY(QString type MEMBER m_type NOTIFY typeChanged)
+    Q_PROPERTY(QString title MEMBER m_title NOTIFY titleChanged)
+    Q_PROPERTY(int status MEMBER m_status NOTIFY statusChanged)
+    Q_PROPERTY(QString instance MEMBER m_instance NOTIFY instanceChanged)
+    Q_PROPERTY(QString detail MEMBER m_detail NOTIFY detailChanged)
 
 
     QString m_type;
@@ -73,6 +73,13 @@ class Response : public QObject
 signals:
     void ready();
     void error();
+    void rateLimitChanged();
+    void typeChanged();
+    void titleChanged();
+    void statusChanged();
+    void instanceChanged();
+    void detailChanged();
+
 private:
     bool preprocessResponse(QNetworkReply *response);
     void restartTimeoutTimer();

src/server.cpp

@@ -12,6 +12,8 @@ QNetworkRequest Server::prepareRequest()
 {
     QNetworkRequest request;
     request.setHeader(QNetworkRequest::ContentTypeHeader, "application/x-www-form-urlencoded");
+    request.setRawHeader("X-Client-Name", STELLAR_QT_SDK_CLIENT_NAME);
+    request.setRawHeader("X-Client-Version", STELLAR_QT_SDK_CLIENT_VERSION);
     return request;
 }
 

src/server.h

@@ -42,6 +42,8 @@ class Server : public QObject
         QNetworkRequest request(rb->requestUri());
         if(rb->streamMode())
             request.setRawHeader("Accept","text/event-stream");
+        request.setRawHeader("X-Client-Name", STELLAR_QT_SDK_CLIENT_NAME);
+        request.setRawHeader("X-Client-Version", STELLAR_QT_SDK_CLIENT_VERSION);
         QNetworkReply * r = m_httpClient->get(request);
         auto response = new T(r);
         response->setParent(this);//so it is not collected by QML

test/servertest.h

@@ -36,6 +36,8 @@ private slots:
 
     void initTestCase()
     {
+        qDebug() <<"qtcpp stellar client name:"<<STELLAR_QT_SDK_CLIENT_NAME;
+        qDebug() <<"qtcpp stellar client version:"<< STELLAR_QT_SDK_CLIENT_VERSION;
         this->setUp();
     }
     void cleanupTestCase()