-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing RegExp properties #1304
Comments
I am currently working on this. |
Depending on how we want to define this issue, I think we could mark some items on the list as done or close this issue.
My feeling is that a big part of the failing tests is based on missing features, either somewhere in boa or in regress. For the most part, I think the basic features are implemented. |
My opinion is that if a function is spec compliant we can consider it done. Tests that depend on regress implementing more things could be open as separate issues and include a link to regress's issue so that we have something tracking it here. If the failing tests depend on things being implemented elsewhere in boa (for example |
I've looked trough all of the failing tests for the RegExp/prototype tests. Here is a list of the related feature / bugfix that is necessary for the tests to pass.
|
Closing because #1434 solved most, if not all, the differences from the spec and we have all properties implemented for |
ECMASCript feature
The description of the RegExp Constructor is here: https://tc39.es/ecma262/#sec-regexp-constructor
Example code
MDN should have enough examples to test, https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp
get RegExp [ @@species ]
RegExp.prototype.constructor
RegExp.prototype [ @@match ] ( string )
RegExp.prototype [ @@matchAll ] ( string )
RegExp.prototype [ @@replace ] ( string, replaceValue )
RegExp.prototype [ @@search ] ( string )
get RegExp.prototype.source
RegExp.prototype [ @@split ] ( string, limit )
Part of the code for
@@replace
is inString.prototype.replace
and should be removed from there.boa/boa/src/builtins/string/mod.rs
Line 648 in 2e75dd8
The text was updated successfully, but these errors were encountered: