-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor / Implement RegExp functions #1350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor regexp match function Refactor regexp matchAll function Refactor regexp test function Implement regexp split function Refactor string split function Implement RegExpStringIterator
Test262 conformance changes:
Fixed tests:
|
Razican
requested review from
RageKnify,
HalidOdat,
Razican,
jasonwilliams,
Lan2u,
0x7D2B and
tofpie
June 20, 2021 13:11
Razican
added
builtins
PRs and Issues related to builtins/intrinsics
bug
Something isn't working
enhancement
New feature or request
execution
Issues or PRs related to code execution
labels
Jun 20, 2021
RageKnify
suggested changes
Jun 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things need correcting, but overall it looks great!
New numbers Test262 conformance changes:
Fixed tests:
|
RageKnify
approved these changes
Jun 21, 2021
Hey @Razican could you give this another review If you have the time? Sorry for the @, but I'm pretty eager to get this merged, because my next PR for regexp named capture groups is basing on this. |
Razican
approved these changes
Jul 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
enhancement
New feature or request
execution
Issues or PRs related to code execution
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1304
It changes the following: