Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Reflect built-in object #1033

Merged
merged 14 commits into from
Mar 10, 2021
Merged

Implement Reflect built-in object #1033

merged 14 commits into from
Mar 10, 2021

Conversation

tofpie
Copy link
Contributor

@tofpie tofpie commented Jan 3, 2021

This Pull Request implements the Reflect built-in object.

It changes the following:

  • Implementation of Reflect built-in object
  • Implement CreateListFromArrayLike and use it in Function.prototype.apply

@codecov
Copy link

codecov bot commented Jan 3, 2021 •
edited
Loading

Codecov Report

Merging #1033 (77f736c) into master (07d5219) will increase coverage by 0.44%.
The diff coverage is 77.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1033      +/-   ##
==========================================
+ Coverage   58.70%   59.15%   +0.44%     
==========================================
  Files         176      177       +1     
  Lines       12391    12534     +143     
==========================================
+ Hits         7274     7414     +140     
- Misses       5117     5120       +3
Impacted Files Coverage Δ
boa/src/builtins/mod.rs 20.58% <0.00%> (-0.63%) ⬇️
boa/src/context.rs 64.93% <ø> (+3.60%) ⬆️
boa/src/object/gcobject.rs 67.10% <ø> (ø)
boa/src/object/internal_methods.rs 62.45% <50.00%> (+5.36%) ⬆️
boa/src/builtins/function/mod.rs 68.75% <66.66%> (-0.90%) ⬇️
boa/src/builtins/reflect/mod.rs 82.06% <82.06%> (ø)
boa/src/object/mod.rs 51.91% <0.00%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d5219...e12d9cb. Read the comment docs.

@Razican Razican added enhancement New feature or request builtins PRs and Issues related to builtins/intrinsics labels Jan 3, 2021
@Razican Razican added this to the v0.11.0 milestone Jan 3, 2021
@Razican
Copy link
Member

Razican commented Jan 3, 2021 •
edited by RageKnify
Loading

Conformance looks very good:

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 24,805 25,112 +307
Ignored 15,587 15,587 0
Failed 38,105 37,798 -307
Panics 26 26 0
Conformance 31.60 31.99 +0.39%

@RageKnify RageKnify self-requested a review January 3, 2021 17:46
RageKnify
RageKnify suggested changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, there are a few things I think can be cleaned up and others that might require some discussion.

boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/reflect/mod.rs Outdated Show resolved Hide resolved
@RageKnify RageKnify mentioned this pull request Jan 5, 2021
Closed
@Razican Razican added the blocked Waiting for another code change label Jan 7, 2021
@RageKnify RageKnify removed the blocked Waiting for another code change label Jan 12, 2021
@RageKnify RageKnify removed this from the v0.11.0 milestone Jan 14, 2021
@RageKnify RageKnify added this to the v0.12.0 milestone Jan 14, 2021
@RageKnify RageKnify mentioned this pull request Feb 6, 2021
Merged
HalidOdat
HalidOdat approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@RageKnify RageKnify merged commit b7ba0b3 into boa-dev:master Mar 10, 2021
@HalidOdat HalidOdat mentioned this pull request May 10, 2021
Closed
@Razican Razican linked an issue May 10, 2021 that may be closed by this pull request
Implement Reflect[ @@toStringTag ] #1232
Closed
Razican pushed a commit that referenced this pull request May 22, 2021
@tofpie @Razican
Implement Reflect built-in object (#1033)
89f0f7a 
* Implement Reflect built-in object

* Use receiver in get and set

* Implement Reflect.construct with newTarget

Co-authored-by: tofpie <tofpie@users.noreply.github.com>
This was referenced May 31, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RageKnify RageKnify RageKnify approved these changes

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Awaiting requested review from Razican

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

@Lan2u Lan2u Awaiting requested review from Lan2u

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.

Implement Reflect[ @@toStringTag ]
4 participants
@tofpie @Razican @HalidOdat @RageKnify