-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added syntax highlighting for numbers, identifiers and template literals #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
New feature or request
cli
Issues and PRs related to the Boa command line interface.
labels
Jan 7, 2021
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1047 +/- ##
==========================================
- Coverage 58.56% 58.26% -0.30%
==========================================
Files 172 172
Lines 11920 11981 +61
==========================================
Hits 6981 6981
- Misses 4939 5000 +61
Continue to review full report at Codecov.
|
Benchmark for ccb3242Click to view benchmark
|
RageKnify
approved these changes
Jan 7, 2021
jevancc
reviewed
Jan 7, 2021
jevancc
reviewed
Jan 7, 2021
Co-authored-by: Jevan Chan <jevan.cnchan@gmail.com>
Benchmark for 68d5c98Click to view benchmark
|
Co-authored-by: Jevan Chan <jevan.cnchan@gmail.com>
Benchmark for 5c44a44Click to view benchmark
|
HalidOdat
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request adds syntax highlighting in our REPL (boa CLI console) for numbers (also binary and hexadecimal), for identifiers, and for template literals.
It should make it easier to see different parts of the code. Here you have a small sneak-peek on how it looks in a dark-themed shell:
Note that the template literals fail until we merge #997.