Refactor: Change Realm::global_object field from Value to GcObject #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RageKnify
force-pushed
the
refactor/global_gcobject
branch
from
916fa00 to
0abe33c
Compare
Test262 conformance changes:
|
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
==========================================
+ Coverage 58.69% 58.71% +0.01%
==========================================
Files 176 176
Lines 12389 12385 -4
==========================================
Hits 7272 7272
+ Misses 5117 5113 -4
Continue to review full report at Codecov.
|
Benchmark for edd499fClick to view benchmark
|
|
I think the clippy lint is a false positive, I tried changing the code to respect it but it results in a |
tofpie
approved these changes
Jan 13, 2021
|
|
||
| // Allow identification of the global object easily | ||
| global.set_data(crate::object::ObjectData::Global); | ||
| global.data = ObjectData::Global; |
There was a problem hiding this comment.
You can add attribute #[allow(clippy::field_reassign_with_default)] on the create method to make clippy happy.
There was a problem hiding this comment.
Does clippy offer a better suggestion?
There was a problem hiding this comment.
The code was triggering a clippy lint, but it seems to be a false positive since the code proposed by clippy wasn't valid.
Benchmark for 030a58cClick to view benchmark
|
|
Sorry i think i removed this branch accidently, i was doing some cleaning up. If you have a locally copy could you pus again? |
Benchmark for 06c5c2aClick to view benchmark
|
Razican
approved these changes
Jan 16, 2021
HalidOdat
approved these changes
Jan 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request works on #577.
It changes the following:
ValuetoGcObjectmake_builin_fn'sparentargument from&Valueto&GcObjectcreate_prototypefunctions to returnGcObjectrather thanValue