Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed spelling #1073

Merged
merged 4 commits into from
Jan 15, 2021
Merged

Fixed spelling #1073

merged 4 commits into from
Jan 15, 2021

Conversation

vishalsodani
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jan 14, 2021 •
edited
Loading

Codecov Report

Merging #1073 (2ce1b54) into master (aa03a7d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1073   +/-   ##
=======================================
  Coverage   58.69%   58.69%           
=======================================
  Files         176      176           
  Lines       12389    12389           
=======================================
  Hits         7272     7272           
  Misses       5117     5117
Impacted Files Coverage Δ
boa/examples/classes.rs 0.00% <ø> (ø)
boa/src/builtins/function/mod.rs 69.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa03a7d...cbec905. Read the comment docs.

tofpie
tofpie suggested changes Jan 14, 2021
View reviewed changes
boa/examples/classes.rs Outdated Show resolved Hide resolved
boa/examples/classes.rs Outdated Show resolved Hide resolved
vishalsodani and others added 2 commits January 15, 2021 10:44
@vishalsodani @tofpie
Update boa/examples/classes.rs
8937dd7 
Co-authored-by: tofpie <75836434+tofpie@users.noreply.github.com>
@vishalsodani @tofpie
Apply suggestions from code review
02a84d7 
Co-authored-by: tofpie <75836434+tofpie@users.noreply.github.com>
tofpie
tofpie approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@tofpie tofpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks!

@tofpie tofpie requested a review from RageKnify January 15, 2021 06:02
Razican
Razican approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes!

@Razican Razican added the documentation update documentation label Jan 15, 2021
@Razican Razican added this to the v0.12.0 milestone Jan 15, 2021
RageKnify
RageKnify suggested changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my proposed changes make it more understandable.
With one in line 69 including an of that should be or.

boa/examples/classes.rs Outdated Show resolved Hide resolved
boa/examples/classes.rs Outdated Show resolved Hide resolved
@RageKnify RageKnify merged commit b28f101 into boa-dev:master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofpie tofpie tofpie approved these changes

@RageKnify RageKnify RageKnify approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
documentation update documentation
Projects
None yet
Milestone
v0.12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@vishalsodani @Razican @RageKnify @tofpie