-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the $262 object to Test262 test runner #1296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
added
enhancement
New feature or request
test
Issues and PRs related to the tests.
labels
May 30, 2021
Test262 conformance changes:
Fixed tests:
|
Benchmark for 19e8280Click to view benchmark
|
Razican
force-pushed
the
feature/tes262_obj
branch
from
May 31, 2021 20:30
d42a317
to
a80687f
Compare
Benchmark for 0995ceeClick to view benchmark
|
Razican
requested review from
RageKnify,
HalidOdat,
jasonwilliams,
0x7D2B,
Lan2u and
tofpie
and removed request for
HalidOdat
June 1, 2021 14:13
Benchmark for 0730b5dClick to view benchmark
|
RageKnify
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the Test262 runner by adding a preliminary version of the
$262
global property.After some trial and error, I saw we still need to implement #893, #1300 and #1301 to be able to implement the rest of the functions, and the
agent
record is even trickier, since it requires being able to run stuff concurrently (but in the same thread). For this we need an executor and an event queue capable of sleeping, stopping execution flow and continuing where we were, which is currently not possible.In any case, It already brings improvements in testing: the cross-realm symbols and some extra tests now work as expected.