-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Array.prototype.copyWithin #1334
Conversation
Test262 conformance changes:
Fixed tests:
Broken tests:
|
95d2f5d
to
d666f34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, looking at the spec, seems like our implementations of has_field
and remove_property
aren't enough, since it should be possible for them to throw.
We should open an issue for that, but I think this implementation is good right now, maybe add some TODO
comments around lines 1595 and 1599.
d666f34
to
b957cfd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge it! Thanks!
This Pull Request checks off a method from #36.
It changes the following:
Had to take a few liberties to make the code more readable, but it should be spec compliant nonetheless. Please tell me if I overlooked something to fix it asap.