Implement spread for objects #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes:
Fixed tests: |
Razican
approved these changes
Aug 27, 2021
FrancisMurillo
force-pushed
the
feature/object-spread-operator
branch
from
87b7131 to
3edcc91
Compare
raskad
reviewed
Aug 28, 2021
raskad
approved these changes
Aug 29, 2021
There was a problem hiding this comment.
Very nice work!
These are the latest test results:
Test262 conformance changes:
| Test result | master count | PR count | difference |
|---|---|---|---|
| Total | 80,685 | 80,685 | 0 |
| Passed | 32,670 | 32,754 | +84 |
| Ignored | 15,818 | 15,818 | 0 |
| Failed | 32,197 | 32,113 | -84 |
| Panics | 0 | 0 | 0 |
| Conformance | 40.49% | 40.59% | +0.10% |
Fixed tests (84):
test/language/expressions/array/spread-obj-spread-order.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-spread-order.js (previously Failed)
test/language/expressions/array/spread-obj-getter-init.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-getter-init.js (previously Failed)
test/language/expressions/array/spread-obj-override-immutable.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-override-immutable.js (previously Failed)
test/language/expressions/array/spread-err-sngl-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/array/spread-err-sngl-err-obj-unresolvable.js (previously Failed)
test/language/expressions/array/spread-obj-mult-spread.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-mult-spread.js (previously Failed)
test/language/expressions/array/spread-obj-mult-spread-getter.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-mult-spread-getter.js (previously Failed)
test/language/expressions/array/spread-err-mult-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/array/spread-err-mult-err-obj-unresolvable.js (previously Failed)
test/language/expressions/array/spread-obj-overrides-prev-properties.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-overrides-prev-properties.js (previously Failed)
test/language/expressions/array/spread-mult-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/array/spread-mult-obj-ident.js (previously Failed)
test/language/expressions/array/spread-obj-getter-descriptor.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-getter-descriptor.js (previously Failed)
test/language/expressions/array/spread-obj-with-overrides.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-with-overrides.js (previously Failed)
test/language/expressions/array/spread-obj-manipulate-outter-obj-in-getter.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-manipulate-outter-obj-in-getter.js (previously Failed)
test/language/expressions/array/spread-sngl-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/array/spread-sngl-obj-ident.js (previously Failed)
test/language/expressions/array/spread-obj-symbol-property.js [strict mode] (previously Failed)
test/language/expressions/array/spread-obj-symbol-property.js (previously Failed)
test/language/expressions/call/spread-obj-spread-order.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-spread-order.js (previously Failed)
test/language/expressions/call/spread-obj-getter-init.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-getter-init.js (previously Failed)
test/language/expressions/call/spread-obj-override-immutable.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-override-immutable.js (previously Failed)
test/language/expressions/call/spread-err-sngl-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/call/spread-err-sngl-err-obj-unresolvable.js (previously Failed)
test/language/expressions/call/spread-obj-mult-spread.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-mult-spread.js (previously Failed)
test/language/expressions/call/spread-obj-mult-spread-getter.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-mult-spread-getter.js (previously Failed)
test/language/expressions/call/spread-err-mult-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/call/spread-err-mult-err-obj-unresolvable.js (previously Failed)
test/language/expressions/call/spread-obj-overrides-prev-properties.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-overrides-prev-properties.js (previously Failed)
test/language/expressions/call/spread-mult-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/call/spread-mult-obj-ident.js (previously Failed)
test/language/expressions/call/spread-obj-getter-descriptor.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-getter-descriptor.js (previously Failed)
test/language/expressions/call/spread-obj-with-overrides.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-with-overrides.js (previously Failed)
test/language/expressions/call/spread-obj-manipulate-outter-obj-in-getter.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-manipulate-outter-obj-in-getter.js (previously Failed)
test/language/expressions/call/spread-sngl-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/call/spread-sngl-obj-ident.js (previously Failed)
test/language/expressions/call/spread-obj-symbol-property.js [strict mode] (previously Failed)
test/language/expressions/call/spread-obj-symbol-property.js (previously Failed)
test/language/expressions/new/spread-obj-spread-order.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-spread-order.js (previously Failed)
test/language/expressions/new/spread-obj-getter-init.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-getter-init.js (previously Failed)
test/language/expressions/new/spread-obj-override-immutable.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-override-immutable.js (previously Failed)
test/language/expressions/new/spread-err-sngl-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/new/spread-err-sngl-err-obj-unresolvable.js (previously Failed)
test/language/expressions/new/spread-obj-mult-spread.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-mult-spread.js (previously Failed)
test/language/expressions/new/spread-obj-mult-spread-getter.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-mult-spread-getter.js (previously Failed)
test/language/expressions/new/spread-err-mult-err-obj-unresolvable.js [strict mode] (previously Failed)
test/language/expressions/new/spread-err-mult-err-obj-unresolvable.js (previously Failed)
test/language/expressions/new/spread-obj-overrides-prev-properties.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-overrides-prev-properties.js (previously Failed)
test/language/expressions/new/spread-mult-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/new/spread-mult-obj-ident.js (previously Failed)
test/language/expressions/new/spread-obj-getter-descriptor.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-getter-descriptor.js (previously Failed)
test/language/expressions/new/spread-obj-with-overrides.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-with-overrides.js (previously Failed)
test/language/expressions/new/spread-obj-manipulate-outter-obj-in-getter.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-manipulate-outter-obj-in-getter.js (previously Failed)
test/language/expressions/new/spread-sngl-obj-ident.js [strict mode] (previously Failed)
test/language/expressions/new/spread-sngl-obj-ident.js (previously Failed)
test/language/expressions/new/spread-obj-symbol-property.js [strict mode] (previously Failed)
test/language/expressions/new/spread-obj-symbol-property.js (previously Failed)
jedel1043
requested changes
Aug 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #214.
It changes the following: