Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(boa): adds normalize method #1369

Merged
merged 2 commits into from
Jul 1, 2021
Merged

feat(boa): adds normalize method #1369

merged 2 commits into from
Jul 1, 2021

Conversation

neeldug
Copy link
Contributor

@neeldug neeldug commented Jun 28, 2021 •
edited by Razican
Loading

This Pull Request progresses on #13.

It changes the following:

  • adds string.prototype.normalize
  • uses unicode_normalization crate

@neeldug
feat(boa): adds normalize method
80a8d67 
- adds string.prototype.normalize
- uses `unicode_normalization` crate

Closes boa-dev#13
@neeldug
Copy link
Contributor Author

neeldug commented Jun 28, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,974 26,990 +16
Ignored 15,616 15,616 0
Failed 36,307 36,291 -16
Panics 0 0 0
Conformance 34.19% 34.21% +0.02%
Fixed tests: 
test/built-ins/String/prototype/normalize/form-is-not-valid-throws.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/form-is-not-valid-throws.js (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string-from-coerced-form.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string-from-coerced-form.js (previously Failed)
test/built-ins/String/prototype/normalize/name.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/name.js (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string.js (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string-using-default-parameter.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/return-normalized-string-using-default-parameter.js (previously Failed)
test/built-ins/String/prototype/normalize/return-abrupt-from-form.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/return-abrupt-from-form.js (previously Failed)
test/built-ins/String/prototype/normalize/return-abrupt-from-this.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/return-abrupt-from-this.js (previously Failed)
test/built-ins/String/prototype/normalize/normalize.js [strict mode] (previously Failed)
test/built-ins/String/prototype/normalize/normalize.js (previously Failed)

Previously 10 erroneously passed as the method didn't exist.

Razican
Razican reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, give a look to my comments :)

boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
boa/src/builtins/string/mod.rs Outdated Show resolved Hide resolved
@neeldug neeldug requested a review from Razican June 29, 2021 18:17
@Razican Razican added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Jun 30, 2021
@Razican Razican added this to the v0.13.0 milestone Jun 30, 2021
Razican
Razican approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Razican Razican merged commit 09efb2e into boa-dev:master Jul 1, 2021
@neeldug neeldug deleted the impl-normalize branch July 1, 2021 18:16
neeldug added a commit to neeldug/boa that referenced this pull request Jul 1, 2021
@neeldug
Revert "feat(boa): adds normalize method (boa-dev#1369)"
3f34c6e 
This reverts commit 09efb2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

@RageKnify RageKnify Awaiting requested review from RageKnify

@jasonwilliams jasonwilliams Awaiting requested review from jasonwilliams

Assignees
No one assigned
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@neeldug @Razican @HalidOdat