Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy errors #1450

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Fix clippy errors #1450

merged 1 commit into from
Aug 6, 2021

Conversation

HalidOdat
Copy link
Member

@HalidOdat HalidOdat commented Jul 31, 2021

This PR fixes clippy lints and makes lints warnings instead of errors. Why do we want this? It's because as clippy becomes "smarter" it's going to detect more, and they all will be errors, breaking our builds. This mostly affects nightly users as they have the latest version of clippy, but it still applies for stable (like now).

Changed CI so clippy lint warnings cause a CI failure

@HalidOdat HalidOdat added the bug Something isn't working label Jul 31, 2021
@HalidOdat HalidOdat added this to the v0.13.0 milestone Jul 31, 2021
@github-actions
Copy link

github-actions bot commented Jul 31, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 28,656 28,656 0
Ignored 15,612 15,612 0
Failed 34,629 34,629 0
Panics 2 2 0
Conformance 36.32% 36.32% 0.00%

@HalidOdat HalidOdat force-pushed the fix/clippy-errors branch from 7c0c268 to 98484ed Compare July 31, 2021 14:55
@github-actions
Copy link

Benchmark for a09a31d

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 277.0±12.21ns 275.1±12.63ns +0.69%
Arithmetic operations (Full) 296.6±8.65µs 292.9±11.57µs +1.26%
Array access (Execution) 6.1±0.16µs 6.4±0.45µs -4.69%
Array access (Full) 325.3±11.46µs 322.5±11.23µs +0.87%
Array creation (Execution) 2.6±0.05ms 2.6±0.08ms 0.00%
Array creation (Full) 3.1±0.08ms 3.1±0.10ms 0.00%
Array pop (Execution) 868.1±25.21µs 859.7±19.16µs +0.98%
Array pop (Full) 1412.2±31.36µs 1400.8±25.87µs +0.81%
Boolean Object Access (Execution) 5.5±0.13µs 5.5±0.16µs 0.00%
Boolean Object Access (Full) 312.5±8.38µs 313.4±15.27µs -0.29%
Clean js (Execution) 719.8±24.10µs 721.6±20.97µs -0.25%
Clean js (Full) 1081.2±22.74µs 1085.9±42.09µs -0.43%
Clean js (Parser) 35.7±1.18µs 35.5±0.70µs +0.56%
Create Realm 433.8±17.11ns 434.1±12.34ns -0.07%
Dynamic Object Property Access (Execution) 4.9±0.12µs 5.0±0.41µs -2.00%
Dynamic Object Property Access (Full) 313.4±4.39µs 316.8±9.60µs -1.07%
Expression (Parser) 6.4±0.24µs 6.3±0.28µs +1.59%
Fibonacci (Execution) 781.8±21.32µs 786.1±29.75µs -0.55%
Fibonacci (Full) 1135.8±44.79µs 1134.1±34.39µs +0.15%
For loop (Execution) 20.2±0.35µs 20.0±0.60µs +1.00%
For loop (Full) 328.6±11.98µs 322.4±6.48µs +1.92%
For loop (Parser) 17.1±0.48µs 17.0±0.41µs +0.59%
Goal Symbols (Parser) 12.6±0.40µs 12.5±0.25µs +0.80%
Hello World (Parser) 3.6±0.10µs 3.7±0.21µs -2.70%
Long file (Parser) 809.1±16.00ns 805.1±42.99ns +0.50%
Mini js (Execution) 655.8±23.40µs 656.8±17.74µs -0.15%
Mini js (Full) 1024.0±48.31µs 1012.8±45.98µs +1.11%
Mini js (Parser) 31.4±0.94µs 31.5±0.94µs -0.32%
Number Object Access (Execution) 4.3±0.16µs 4.3±0.12µs 0.00%
Number Object Access (Full) 308.8±11.44µs 313.4±15.23µs -1.47%
Object Creation (Execution) 4.4±0.20µs 4.3±0.10µs +2.33%
Object Creation (Full) 314.7±9.51µs 313.2±11.05µs +0.48%
RegExp (Execution) 12.9±0.21µs 12.9±0.44µs 0.00%
RegExp (Full) 326.9±51.92µs 321.4±10.32µs +1.71%
RegExp Literal (Execution) 12.9±0.20µs 12.9±0.42µs 0.00%
RegExp Literal (Full) 331.2±12.88µs 327.1±9.31µs +1.25%
RegExp Literal Creation (Execution) 9.7±0.27µs 9.7±0.24µs 0.00%
RegExp Literal Creation (Full) 318.1±20.68µs 318.0±13.29µs +0.03%
Static Object Property Access (Execution) 4.7±0.56µs 4.5±0.13µs +4.44%
Static Object Property Access (Full) 313.3±9.04µs 312.9±11.88µs +0.13%
String Object Access (Execution) 7.1±0.26µs 7.2±0.46µs -1.39%
String Object Access (Full) 316.5±8.87µs 317.4±8.76µs -0.28%
String comparison (Execution) 6.4±0.21µs 6.3±0.13µs +1.59%
String comparison (Full) 313.6±7.32µs 314.0±6.66µs -0.13%
String concatenation (Execution) 4.8±0.16µs 4.9±0.13µs -2.04%
String concatenation (Full) 310.6±7.72µs 306.2±6.38µs +1.44%
String copy (Execution) 3.8±0.11µs 3.9±0.15µs -2.56%
String copy (Full) 308.2±14.16µs 310.0±28.23µs -0.58%
Symbols (Execution) 3.3±0.12µs 3.2±0.08µs +3.12%
Symbols (Full) 287.2±5.54µs 291.1±13.27µs -1.34%

@github-actions
Copy link

Benchmark for 81d7faf

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 223.9±0.35ns 224.5±0.27ns -0.27%
Arithmetic operations (Full) 239.4±1.07µs 239.7±0.34µs -0.13%
Array access (Execution) 5.0±0.03µs 5.0±0.02µs 0.00%
Array access (Full) 263.6±0.35µs 263.6±1.05µs 0.00%
Array creation (Execution) 2.1±0.00ms 2.2±0.01ms -4.55%
Array creation (Full) 2.5±0.00ms 2.5±0.00ms 0.00%
Array pop (Execution) 698.4±2.88µs 712.6±3.81µs -1.99%
Array pop (Full) 1154.6±19.89µs 1150.3±2.26µs +0.37%
Boolean Object Access (Execution) 4.6±0.01µs 4.6±0.01µs 0.00%
Boolean Object Access (Full) 255.1±0.33µs 255.2±0.32µs -0.04%
Clean js (Execution) 583.4±3.44µs 587.1±3.03µs -0.63%
Clean js (Full) 879.8±2.29µs 879.7±4.17µs +0.01%
Clean js (Parser) 31.5±0.24µs 31.5±0.05µs 0.00%
Create Realm 353.4±0.25ns 353.0±0.26ns +0.11%
Dynamic Object Property Access (Execution) 4.0±0.02µs 4.0±0.01µs 0.00%
Dynamic Object Property Access (Full) 257.3±0.27µs 259.8±0.32µs -0.96%
Expression (Parser) 5.3±0.03µs 5.3±0.01µs 0.00%
Fibonacci (Execution) 637.2±2.60µs 638.6±0.76µs -0.22%
Fibonacci (Full) 927.7±0.74µs 929.3±1.49µs -0.17%
For loop (Execution) 16.2±0.03µs 16.2±0.03µs 0.00%
For loop (Full) 265.9±0.68µs 267.5±0.52µs -0.60%
For loop (Parser) 14.8±0.12µs 14.9±0.03µs -0.67%
Goal Symbols (Parser) 10.7±0.07µs 10.7±0.02µs 0.00%
Hello World (Parser) 3.1±0.03µs 3.1±0.01µs 0.00%
Long file (Parser) 744.0±20.25ns 749.1±16.53ns -0.68%
Mini js (Execution) 530.8±3.88µs 538.9±2.52µs -1.50%
Mini js (Full) 825.8±5.32µs 825.5±3.00µs +0.04%
Mini js (Parser) 27.4±0.04µs 27.5±0.02µs -0.36%
Number Object Access (Execution) 3.5±0.00µs 3.6±0.00µs -2.78%
Number Object Access (Full) 251.6±0.74µs 253.7±0.82µs -0.83%
Object Creation (Execution) 3.5±0.01µs 3.5±0.02µs 0.00%
Object Creation (Full) 256.9±0.57µs 256.4±0.47µs +0.20%
RegExp (Execution) 10.5±0.07µs 10.6±0.05µs -0.94%
RegExp (Full) 262.3±0.53µs 262.7±0.39µs -0.15%
RegExp Literal (Execution) 10.6±0.05µs 10.6±0.05µs 0.00%
RegExp Literal (Full) 268.4±0.50µs 269.8±1.07µs -0.52%
RegExp Literal Creation (Execution) 7.9±0.03µs 7.9±0.04µs 0.00%
RegExp Literal Creation (Full) 262.2±0.57µs 258.4±0.51µs +1.47%
Static Object Property Access (Execution) 3.7±0.07µs 3.7±0.02µs 0.00%
Static Object Property Access (Full) 255.6±0.24µs 257.8±0.45µs -0.85%
String Object Access (Execution) 5.8±0.01µs 6.0±0.03µs -3.33%
String Object Access (Full) 256.7±0.58µs 260.7±0.61µs -1.53%
String comparison (Execution) 5.1±0.02µs 5.1±0.01µs 0.00%
String comparison (Full) 257.5±0.85µs 257.9±0.48µs -0.16%
String concatenation (Execution) 3.9±0.01µs 3.9±0.01µs 0.00%
String concatenation (Full) 250.7±0.47µs 253.7±0.38µs -1.18%
String copy (Execution) 3.1±0.01µs 3.0±0.01µs +3.33%
String copy (Full) 246.1±0.32µs 246.7±0.39µs -0.24%
Symbols (Execution) 2.6±0.00µs 2.6±0.01µs 0.00%
Symbols (Full) 234.9±0.51µs 236.5±0.31µs -0.68%

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. I would still not change all clippy lints to warnings though. I think we can leave them as clippy does. But I'm even in favour of leaving them as errors, even if that will break the CI on some clippy releases.

boa/src/lib.rs Outdated Show resolved Hide resolved
.github/workflows/rust.yml Outdated Show resolved Hide resolved
boa/src/value/tests.rs Show resolved Hide resolved
@HalidOdat HalidOdat force-pushed the fix/clippy-errors branch 2 times, most recently from 3c520c8 to 92fcaa3 Compare August 6, 2021 17:20
@HalidOdat HalidOdat merged commit 4b497ea into master Aug 6, 2021
@HalidOdat HalidOdat deleted the fix/clippy-errors branch August 6, 2021 17:24
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Benchmark for b49217e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 224.3±0.35ns 224.3±0.62ns 0.00%
Arithmetic operations (Full) 240.9±0.45µs 240.3±0.29µs +0.25%
Array access (Execution) 5.0±0.02µs 4.9±0.01µs +2.04%
Array access (Full) 262.9±0.60µs 260.1±0.50µs +1.08%
Array creation (Execution) 2.1±0.00ms 2.1±0.00ms 0.00%
Array creation (Full) 2.5±0.00ms 2.5±0.00ms 0.00%
Array pop (Execution) 701.5±3.64µs 700.0±1.61µs +0.21%
Array pop (Full) 1155.0±1.49µs 1146.3±4.31µs +0.76%
Boolean Object Access (Execution) 4.6±0.02µs 4.6±0.01µs 0.00%
Boolean Object Access (Full) 255.6±0.49µs 256.8±0.52µs -0.47%
Clean js (Execution) 583.2±5.63µs 583.3±2.93µs -0.02%
Clean js (Full) 884.1±2.97µs 883.0±2.53µs +0.12%
Clean js (Parser) 31.3±0.29µs 31.2±0.22µs +0.32%
Create Realm 352.9±0.24ns 354.3±1.36ns -0.40%
Dynamic Object Property Access (Execution) 3.9±0.01µs 4.0±0.01µs -2.50%
Dynamic Object Property Access (Full) 258.9±0.67µs 257.2±0.24µs +0.66%
Expression (Parser) 5.2±0.03µs 5.3±0.01µs -1.89%
Fibonacci (Execution) 649.1±2.42µs 634.7±0.86µs +2.27%
Fibonacci (Full) 926.8±0.77µs 927.2±1.15µs -0.04%
For loop (Execution) 16.4±0.03µs 16.3±0.05µs +0.61%
For loop (Full) 270.9±6.00µs 264.7±0.50µs +2.34%
For loop (Parser) 14.8±0.13µs 14.9±0.18µs -0.67%
Goal Symbols (Parser) 10.8±0.05µs 10.7±0.09µs +0.93%
Hello World (Parser) 3.1±0.05µs 3.1±0.02µs 0.00%
Long file (Parser) 750.8±20.08ns 743.7±16.57ns +0.95%
Mini js (Execution) 531.2±3.79µs 530.7±3.48µs +0.09%
Mini js (Full) 830.5±2.66µs 827.4±1.96µs +0.37%
Mini js (Parser) 27.4±0.03µs 27.3±0.03µs +0.37%
Number Object Access (Execution) 3.6±0.00µs 3.6±0.00µs 0.00%
Number Object Access (Full) 252.7±0.45µs 250.3±0.51µs +0.96%
Object Creation (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Object Creation (Full) 255.0±0.59µs 254.7±0.45µs +0.12%
RegExp (Execution) 10.6±0.05µs 10.6±0.06µs 0.00%
RegExp (Full) 260.8±0.37µs 258.2±0.36µs +1.01%
RegExp Literal (Execution) 10.5±0.05µs 10.6±0.06µs -0.94%
RegExp Literal (Full) 267.9±0.57µs 265.1±0.63µs +1.06%
RegExp Literal Creation (Execution) 7.8±0.03µs 7.9±0.03µs -1.27%
RegExp Literal Creation (Full) 258.0±0.48µs 256.7±0.30µs +0.51%
Static Object Property Access (Execution) 3.7±0.01µs 3.7±0.01µs 0.00%
Static Object Property Access (Full) 255.4±0.37µs 253.4±0.53µs +0.79%
String Object Access (Execution) 6.0±0.04µs 5.8±0.02µs +3.45%
String Object Access (Full) 257.7±0.53µs 258.2±0.55µs -0.19%
String comparison (Execution) 5.1±0.03µs 5.1±0.01µs 0.00%
String comparison (Full) 258.4±0.35µs 258.1±2.57µs +0.12%
String concatenation (Execution) 3.9±0.01µs 3.9±0.03µs 0.00%
String concatenation (Full) 254.4±1.61µs 250.1±0.28µs +1.72%
String copy (Execution) 3.0±0.01µs 3.1±0.01µs -3.23%
String copy (Full) 247.1±0.39µs 249.7±0.58µs -1.04%
Symbols (Execution) 2.6±0.01µs 2.6±0.01µs 0.00%
Symbols (Full) 236.2±0.31µs 234.1±0.42µs +0.90%

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Benchmark for fc4bf8e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 224.1±0.41ns 225.2±1.11ns -0.49%
Arithmetic operations (Full) 238.6±1.99µs 239.5±0.27µs -0.38%
Array access (Execution) 5.0±0.02µs 4.9±0.01µs +2.04%
Array access (Full) 260.9±0.54µs 261.5±0.58µs -0.23%
Array creation (Execution) 2.2±0.00ms 2.1±0.01ms +4.76%
Array creation (Full) 2.5±0.00ms 2.5±0.00ms 0.00%
Array pop (Execution) 713.0±1.89µs 699.4±3.15µs +1.94%
Array pop (Full) 1149.1±1.43µs 1151.9±1.66µs -0.24%
Boolean Object Access (Execution) 4.6±0.01µs 4.6±0.01µs 0.00%
Boolean Object Access (Full) 255.3±0.50µs 255.6±0.35µs -0.12%
Clean js (Execution) 589.3±3.29µs 582.7±3.13µs +1.13%
Clean js (Full) 882.1±2.57µs 884.4±11.58µs -0.26%
Clean js (Parser) 31.1±0.22µs 31.2±0.23µs -0.32%
Create Realm 353.9±0.21ns 355.6±0.36ns -0.48%
Dynamic Object Property Access (Execution) 4.0±0.03µs 4.1±0.02µs -2.44%
Dynamic Object Property Access (Full) 257.5±0.40µs 259.8±0.44µs -0.89%
Expression (Parser) 5.3±0.03µs 5.3±0.02µs 0.00%
Fibonacci (Execution) 643.4±0.68µs 635.2±3.59µs +1.29%
Fibonacci (Full) 926.8±0.90µs 931.7±1.14µs -0.53%
For loop (Execution) 16.6±0.11µs 16.5±0.04µs +0.61%
For loop (Full) 265.1±0.38µs 266.1±0.42µs -0.38%
For loop (Parser) 14.9±0.10µs 14.8±0.16µs +0.68%
Goal Symbols (Parser) 10.8±0.07µs 10.8±0.11µs 0.00%
Hello World (Parser) 3.1±0.04µs 3.1±0.02µs 0.00%
Long file (Parser) 763.2±12.56ns 746.1±15.57ns +2.29%
Mini js (Execution) 536.6±3.78µs 530.4±3.40µs +1.17%
Mini js (Full) 826.2±2.50µs 826.3±2.26µs -0.01%
Mini js (Parser) 27.4±0.03µs 27.5±0.04µs -0.36%
Number Object Access (Execution) 3.5±0.01µs 3.6±0.01µs -2.78%
Number Object Access (Full) 251.2±0.44µs 251.9±0.23µs -0.28%
Object Creation (Execution) 3.5±0.01µs 3.5±0.02µs 0.00%
Object Creation (Full) 254.3±0.44µs 256.1±2.75µs -0.70%
RegExp (Execution) 10.6±0.06µs 10.6±0.06µs 0.00%
RegExp (Full) 260.6±2.69µs 262.3±0.48µs -0.65%
RegExp Literal (Execution) 10.6±0.16µs 10.6±0.06µs 0.00%
RegExp Literal (Full) 267.2±0.39µs 266.6±0.65µs +0.23%
RegExp Literal Creation (Execution) 8.0±0.04µs 7.9±0.03µs +1.27%
RegExp Literal Creation (Full) 259.5±0.31µs 258.5±0.35µs +0.39%
Static Object Property Access (Execution) 3.7±0.01µs 3.7±0.01µs 0.00%
Static Object Property Access (Full) 254.6±0.37µs 257.9±2.42µs -1.28%
String Object Access (Execution) 5.8±0.01µs 5.9±0.02µs -1.69%
String Object Access (Full) 259.6±0.41µs 257.0±0.44µs +1.01%
String comparison (Execution) 5.1±0.02µs 5.1±0.01µs 0.00%
String comparison (Full) 256.3±0.46µs 256.8±0.56µs -0.19%
String concatenation (Execution) 3.9±0.01µs 3.9±0.01µs 0.00%
String concatenation (Full) 252.1±0.80µs 249.8±0.57µs +0.92%
String copy (Execution) 3.1±0.01µs 3.1±0.01µs 0.00%
String copy (Full) 245.3±0.45µs 246.2±0.38µs -0.37%
Symbols (Execution) 2.6±0.01µs 2.6±0.01µs 0.00%
Symbols (Full) 234.9±1.00µs 234.9±0.38µs 0.00%

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Benchmark for 599f72e

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 246.6±10.83ns 252.0±14.25ns -2.14%
Arithmetic operations (Full) 263.8±14.60µs 285.2±4.89µs -7.50%
Array access (Execution) 5.1±0.32µs 5.3±0.40µs -3.77%
Array access (Full) 271.0±16.06µs 278.3±11.49µs -2.62%
Array creation (Execution) 2.2±0.12ms 2.4±0.06ms -8.33%
Array creation (Full) 2.6±0.16ms 2.9±0.08ms -10.34%
Array pop (Execution) 776.9±44.12µs 781.5±25.43µs -0.59%
Array pop (Full) 1193.9±75.83µs 1268.9±57.56µs -5.91%
Boolean Object Access (Execution) 4.5±0.24µs 4.8±0.30µs -6.25%
Boolean Object Access (Full) 258.5±12.64µs 279.6±9.93µs -7.55%
Clean js (Execution) 680.6±18.91µs 600.4±32.10µs +13.36%
Clean js (Full) 964.5±52.18µs 988.8±25.50µs -2.46%
Clean js (Parser) 31.1±1.72µs 32.0±1.19µs -2.81%
Create Realm 408.2±16.15ns 367.2±22.53ns +11.17%
Dynamic Object Property Access (Execution) 4.2±0.21µs 4.5±0.15µs -6.67%
Dynamic Object Property Access (Full) 287.3±11.84µs 274.8±14.29µs +4.55%
Expression (Parser) 5.9±0.23µs 5.6±0.24µs +5.36%
Fibonacci (Execution) 658.9±38.77µs 698.8±24.98µs -5.71%
Fibonacci (Full) 979.9±54.91µs 951.2±55.72µs +3.02%
For loop (Execution) 16.8±1.00µs 16.7±0.88µs +0.60%
For loop (Full) 277.3±15.73µs 270.8±13.25µs +2.40%
For loop (Parser) 15.8±0.57µs 15.8±0.59µs 0.00%
Goal Symbols (Parser) 11.1±0.45µs 11.3±0.43µs -1.77%
Hello World (Parser) 3.3±0.15µs 3.2±0.12µs +3.12%
Long file (Parser) 738.8±25.35ns 734.4±25.35ns +0.60%
Mini js (Execution) 561.6±32.81µs 539.6±30.94µs +4.08%
Mini js (Full) 945.8±26.50µs 906.8±25.80µs +4.30%
Mini js (Parser) 27.0±1.40µs 29.3±0.76µs -7.85%
Number Object Access (Execution) 3.5±0.19µs 3.5±0.20µs 0.00%
Number Object Access (Full) 283.1±8.26µs 274.9±9.75µs +2.98%
Object Creation (Execution) 4.0±0.17µs 3.9±0.14µs +2.56%
Object Creation (Full) 281.2±12.59µs 271.5±14.08µs +3.57%
RegExp (Execution) 12.1±0.44µs 12.0±0.53µs +0.83%
RegExp (Full) 272.1±18.46µs 289.2±14.48µs -5.91%
RegExp Literal (Execution) 12.4±0.48µs 11.8±0.51µs +5.08%
RegExp Literal (Full) 273.3±14.71µs 294.4±7.88µs -7.17%
RegExp Literal Creation (Execution) 9.2±0.33µs 8.8±0.41µs +4.55%
RegExp Literal Creation (Full) 286.8±10.46µs 283.4±10.27µs +1.20%
Static Object Property Access (Execution) 4.2±0.13µs 4.1±0.13µs +2.44%
Static Object Property Access (Full) 293.1±10.72µs 280.6±9.86µs +4.45%
String Object Access (Execution) 6.3±0.32µs 6.4±0.24µs -1.56%
String Object Access (Full) 273.0±15.93µs 278.5±7.19µs -1.97%
String comparison (Execution) 5.3±0.27µs 5.5±0.35µs -3.64%
String comparison (Full) 281.8±15.73µs 277.7±10.83µs +1.48%
String concatenation (Execution) 4.5±0.12µs 4.1±0.26µs +9.76%
String concatenation (Full) 271.5±14.84µs 283.1±10.71µs -4.10%
String copy (Execution) 3.2±0.17µs 3.2±0.17µs 0.00%
String copy (Full) 276.0±13.46µs 269.3±7.63µs +2.49%
Symbols (Execution) 2.9±0.11µs 2.7±0.15µs +7.41%
Symbols (Full) 240.7±13.83µs 238.4±14.87µs +0.96%

@github-actions
Copy link

github-actions bot commented Aug 6, 2021

Benchmark for be87e59

Click to view benchmark
Test PR Benchmark Master Benchmark %
Arithmetic operations (Execution) 221.4±0.30ns 247.5±4.69ns -10.55%
Arithmetic operations (Full) 238.6±0.41µs 214.0±0.24µs +11.50%
Array access (Execution) 5.0±0.01µs 5.1±0.02µs -1.96%
Array access (Full) 259.4±0.33µs 230.0±0.40µs +12.78%
Array creation (Execution) 2.1±0.00ms 2.1±0.01ms 0.00%
Array creation (Full) 2.2±0.01ms 2.2±0.00ms 0.00%
Array pop (Execution) 693.9±2.43µs 693.4±2.13µs +0.07%
Array pop (Full) 1012.5±1.40µs 1008.3±1.19µs +0.42%
Boolean Object Access (Execution) 4.5±0.02µs 4.5±0.01µs 0.00%
Boolean Object Access (Full) 256.4±0.40µs 225.4±0.27µs +13.75%
Clean js (Execution) 582.7±2.73µs 583.3±2.64µs -0.10%
Clean js (Full) 879.0±3.00µs 774.2±2.25µs +13.54%
Clean js (Parser) 31.4±0.05µs 31.5±0.08µs -0.32%
Create Realm 354.6±0.85ns 352.4±0.40ns +0.62%
Dynamic Object Property Access (Execution) 4.1±0.02µs 4.0±0.02µs +2.50%
Dynamic Object Property Access (Full) 256.0±0.74µs 226.2±0.44µs +13.17%
Expression (Parser) 5.3±0.00µs 5.4±0.01µs -1.85%
Fibonacci (Execution) 638.3±1.57µs 639.3±1.37µs -0.16%
Fibonacci (Full) 819.0±0.91µs 829.2±1.95µs -1.23%
For loop (Execution) 16.3±0.04µs 16.3±0.03µs 0.00%
For loop (Full) 233.8±0.36µs 233.6±0.63µs +0.09%
For loop (Parser) 14.9±0.11µs 15.0±0.06µs -0.67%
Goal Symbols (Parser) 10.8±0.03µs 10.9±0.02µs -0.92%
Hello World (Parser) 3.1±0.01µs 3.1±0.01µs 0.00%
Long file (Parser) 744.7±16.97ns 739.0±18.73ns +0.77%
Mini js (Execution) 528.6±5.70µs 530.4±2.83µs -0.34%
Mini js (Full) 820.8±2.70µs 821.2±1.95µs -0.05%
Mini js (Parser) 27.5±0.03µs 27.4±0.03µs +0.36%
Number Object Access (Execution) 3.5±0.03µs 3.5±0.01µs 0.00%
Number Object Access (Full) 251.1±0.38µs 252.7±0.52µs -0.63%
Object Creation (Execution) 3.5±0.01µs 3.5±0.01µs 0.00%
Object Creation (Full) 223.6±0.44µs 255.1±0.29µs -12.35%
RegExp (Execution) 11.0±0.04µs 11.0±0.04µs 0.00%
RegExp (Full) 261.0±0.73µs 230.4±0.25µs +13.28%
RegExp Literal (Execution) 11.0±0.06µs 11.0±0.06µs 0.00%
RegExp Literal (Full) 266.8±0.38µs 235.4±0.41µs +13.34%
RegExp Literal Creation (Execution) 8.1±0.03µs 8.2±0.02µs -1.22%
RegExp Literal Creation (Full) 257.4±0.44µs 227.3±0.29µs +13.24%
Static Object Property Access (Execution) 3.7±0.01µs 3.7±0.01µs 0.00%
Static Object Property Access (Full) 255.4±0.49µs 224.1±0.32µs +13.97%
String Object Access (Execution) 5.8±0.03µs 5.8±0.02µs 0.00%
String Object Access (Full) 257.0±0.71µs 228.0±0.32µs +12.72%
String comparison (Execution) 5.2±0.01µs 5.2±0.01µs 0.00%
String comparison (Full) 256.3±0.64µs 256.9±0.50µs -0.23%
String concatenation (Execution) 3.9±0.02µs 3.9±0.01µs 0.00%
String concatenation (Full) 251.8±0.55µs 252.9±0.31µs -0.43%
String copy (Execution) 3.1±0.01µs 3.1±0.01µs 0.00%
String copy (Full) 245.3±0.39µs 247.7±0.32µs -0.97%
Symbols (Execution) 2.6±0.01µs 2.6±0.00µs 0.00%
Symbols (Full) 207.1±0.38µs 235.0±0.40µs -11.87%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants