-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy errors #1450
Merged
Merged
Fix clippy errors #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes:
|
HalidOdat
force-pushed
the
fix/clippy-errors
branch
from
July 31, 2021 14:55
7c0c268
to
98484ed
Compare
Benchmark for a09a31dClick to view benchmark
|
Benchmark for 81d7fafClick to view benchmark
|
RageKnify
approved these changes
Jul 31, 2021
Razican
reviewed
Jul 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. I would still not change all clippy lints to warnings though. I think we can leave them as clippy does. But I'm even in favour of leaving them as errors, even if that will break the CI on some clippy releases.
HalidOdat
force-pushed
the
fix/clippy-errors
branch
2 times, most recently
from
August 6, 2021 17:20
3c520c8
to
92fcaa3
Compare
HalidOdat
force-pushed
the
fix/clippy-errors
branch
from
August 6, 2021 17:23
92fcaa3
to
22634ac
Compare
Benchmark for b49217eClick to view benchmark
|
Benchmark for fc4bf8eClick to view benchmark
|
Benchmark for 599f72eClick to view benchmark
|
Benchmark for be87e59Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes clippy lints and makes lints warnings instead of errors. Why do we want this? It's because as clippy becomes "smarter" it's going to detect more, and they all will be errors, breaking our builds. This mostly affects nightly users as they have the latest version of clippy, but it still applies for stable (like now).
Changed CI so clippy lint warnings cause a CI failure