-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "js" feature for getrandom for WebAssembly builds #1521
Conversation
Test262 conformance changes:
Fixed tests (2):
|
Benchmark for f9daa93Click to view benchmark
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, minor nitpick
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good just needs a rebase! :)
5d43ed2
to
0fd64aa
Compare
This Pull Request fixes/closes #1475.
It changes the following:
getrandom
dependency, to be able to build it.Interestingly, our build check didn't see this issue. Maybe we should check if it's a cache issue.
We are also getting this warning we should somehow fix (but I don't know how):