-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the Math
builtin object
#1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test262 conformance changes:
Fixed tests (14):
|
jedel1043
force-pushed
the
math_docs
branch
3 times, most recently
from
September 17, 2021 06:25
75db1c7
to
4c69db7
Compare
jedel1043
force-pushed
the
math_docs
branch
from
September 17, 2021 06:32
4c69db7
to
9967ad1
Compare
jedel1043
changed the title
Document the
Refactor the Sep 17, 2021
Math
builtin objectMath
builtin object
jedel1043
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
documentation
update documentation
labels
Sep 17, 2021
raskad
approved these changes
Sep 17, 2021
RageKnify
reviewed
Sep 19, 2021
RageKnify
reviewed
Sep 19, 2021
RageKnify
reviewed
Sep 19, 2021
RageKnify
reviewed
Sep 19, 2021
RageKnify
reviewed
Sep 19, 2021
RageKnify
suggested changes
Sep 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small corrections
jedel1043
force-pushed
the
math_docs
branch
from
September 20, 2021 17:06
9967ad1
to
3b8fa7a
Compare
RageKnify
approved these changes
Sep 21, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
documentation
update documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request changes the following:
max
,min
,log
,log2
andlog10
spec compliant.Math
builtin methods.get_or_undefined
.