Moved to a workspace architecture

[Razican]

This fixes #239, and superseeds #241.

I also took the opportunity to generate the Cargo.lock file with the new Rust 1.41+ format, and add a couple of build profiles. Everything seems to be working fine, except for the wasm feature.

When building it like that, I seem to be getting a ./pkg/ directory, with an empty index.js file. This ./pkg/ directory seems not to be ignored by gitignore. Do you know how this works? I'm not familiarized with Rust-wasm setups.

[adumbidiot]

Was this PR supposed to address #140 too?

[adumbidiot]

Looks like wasm-pack doesn't support workspaces.

[adumbidiot]

I take that back. We can manually specify the crate to wasmify in the webpack plugin config and change the outdir. Reference: https://github.com/wasm-tool/wasm-pack-plugin.

The pkg dir was empty before because wasm-pack failed.

[Razican]

Was this PR supposed to address #140 too?

Actually, not, but let's do that too!

I take that back. We can manually specify the crate to wasmify in the webpack plugin config and change the outdir. Reference: wasm-tool/wasm-pack-plugin.

The pkg dir was empty before because wasm-pack failed.

I will check that asap and update the PR :) thanks for the pointer!

[Razican]

The build error is due to the binary being run in the benchmarks by default (where criterion is not available). This can be solved by passing -p Boa to cargo bench, done in the criterion compare action (https://github.com/jasonwilliams/criterion-compare-action/blob/master/main.js#L14-L18).

This should probably be added to the benchmarks GitHub action too, and it should be generic enough to accept an input "package" parameter.

[jasonwilliams]

Seems ok from what i can see.
Done https://github.com/jasonwilliams/criterion-compare-action/blob/master/main.js

cargo bench -p Boa -- --save-baseline changes doesn't seem to be working :/

[Razican]

Checking at the output of the action run, it seems that the change is not being run, it's still running cargo bench -- --save-baseline changes :/

It's like it had some cache for the action. I'm guessing that versioning it should help. I will add the commit hash, to check it just in case.

[Razican]

It seems it doesn't work. It's using the minified version in dist/, so that needs to be re-generated.

[jasonwilliams]

That makes sense, I’ll try it again when I have time

[jasonwilliams]

built and updated action

[jasonwilliams]

seems to be weirdly cached, im going to try referencing the commit

[jasonwilliams]

Looks like we've finally fixed it @Razican

[Razican]

Cool! we can merge then. Still, it's weird it gets cached. We can maybe try switching to the master branch in the future :)

[jasonwilliams]

Ok lets do this, it looks fine to me