-
-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added continuous integration for windows #318
Added continuous integration for windows #318
Conversation
Could be interesting to add benchmarks, yes. And I think we should have at least one benchmark of both lexing and parsing, that could be checked in the future when we merge both. We can take this opportunity to do that. I would also add a benchmark of a bit more complex program too than a |
Oh, and I think we should upgrade the |
I actually did this but it caused problems so I had to revert. I’m sure this is fixable, but if you hit the same issue that seems to be what it is. For the CI workflow v2 should work fine as there’s no branch switching happening |
I upgraded CI to checkout@v2 and it seems to be working fine. I think this is ready to merge. :) |
I think it would be interesting to benchmark on Windows too, since for example Jemallocator is Linux-only. |
I think we should do this in another PR. :) BTW I'm not very knowledgeable of how the benchmarks are set or github actions for that matter. Edit: I can add in CI a step to see if benchmark compiles on Linux and Windows |
+1 benchmarking being done in a separate PR |
I added continuous integration for windows.
Check
toCheck on Linux
Check on Windows
Test Suite
toTest Suite on Linux
Test Suite on Windows
I did not add
Rust Fmt on Windows
andRust Clippy on Windows
, since there are not os specific.what do you think? @Razican @jasonwilliams
Also should I add for benchmark too?