Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put JSON functions on the object, not the prototype #325

Merged
merged 7 commits into from
Apr 26, 2020
Merged

Put JSON functions on the object, not the prototype #325

merged 7 commits into from
Apr 26, 2020

Conversation

coolreader18
Copy link
Contributor

No description provided.

@coolreader18 coolreader18 changed the title Move JSON functions to the object, not the prototype Put JSON functions to the object, not the prototype Apr 16, 2020
@coolreader18 coolreader18 changed the title Put JSON functions to the object, not the prototype Put JSON functions on the object, not the prototype Apr 16, 2020
HalidOdat
HalidOdat reviewed Apr 16, 2020
View reviewed changes
Copy link
Member

@HalidOdat HalidOdat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very Nice!
I think it would be great if you could add tests for JSON methods like array module. :)

@HalidOdat HalidOdat added bug Something isn't working duplicate This issue or pull request already exists labels Apr 16, 2020
@Razican
Copy link
Member

Razican commented Apr 17, 2020

Hi @HalidOdat is this a duplicate? Could we link the duplicate issue?

@HalidOdat
Copy link
Member

Hi @HalidOdat is this a duplicate? Could we link the duplicate issue?

This PR solves the same issue but it needs a rebase #270

Razican
Razican reviewed Apr 22, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look pretty good, almost ready for a merge. Could you check my comments and see if they make sense?

boa/src/builtins/json.rs Outdated Show resolved Hide resolved
boa/src/builtins/json.rs Outdated Show resolved Hide resolved
boa/src/builtins/json.rs Outdated Show resolved Hide resolved
@Razican Razican added this to the v0.8.0 milestone Apr 22, 2020
@Razican Razican requested a review from HalidOdat April 25, 2020 11:36
@Razican Razican merged commit 271e2b4 into boa-dev:master Apr 26, 2020
@Razican Razican mentioned this pull request Apr 26, 2020
Closed
@Razican Razican mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HalidOdat HalidOdat HalidOdat approved these changes

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@coolreader18 @Razican @HalidOdat