-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix function object constructable/callable #409
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for a0da1a2Click to view benchmark
|
Benchmark for 34a4151Click to view benchmark
|
Benchmark for 5c092baClick to view benchmark
|
jasonwilliams
approved these changes
May 25, 2020
- Maded arrow functions non-constructable - Simplified Function object and removed FunctionKind - Rnamed create_ordinary -> ordinary, create_builtin -> builtin - Added name and length properties in global objects
HalidOdat
force-pushed
the
fix/construct-and-call
branch
from
May 25, 2020 16:02
70f2ef4
to
317b4c5
Compare
If everything is good with this PR, could we merge it. It has some changes that would make it easier to implement #419 . |
Razican
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
FunctionKind
and cleanupname
property to global objects. example: BigInt.name === "BigInt"length
property to global objects. example: Boolean.length === 1Not all function objects are constructable or callable for example:
More informations see: https://stackoverflow.com/a/40922715