-
-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specification compliant ToBigInt
(to_bigint
)
#450
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HalidOdat
added
bug
Something isn't working
builtins
PRs and Issues related to builtins/intrinsics
labels
Jun 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 66.09% 66.24% +0.15%
==========================================
Files 128 131 +3
Lines 8992 9039 +47
==========================================
+ Hits 5943 5988 +45
- Misses 3049 3051 +2
Continue to review full report at Codecov.
|
Benchmark for 2be3d4dClick to view benchmark
|
Benchmark for 35b878aClick to view benchmark
|
I think this is ready for review :) |
- Merged Ast `BigInt` to Builtin `BigInt`. - Split `BigInt` logic to separate files. - Added `builtins/bigint/operations.rs` for `BigInt` operations. - Added `builtins/bigint/conversions.rs` for `BigInt` conversions. - Added` builtins/bigint/equality.rs` for `BigInt` equality checking. - Added tests.
Benchmark for 3956d50Click to view benchmark
|
jasonwilliams
approved these changes
Jun 5, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the following:
ValueData
sto_bigint
=>Interpreter
sto_bigint
BigInt
to BuiltinBigInt
.BigInt
logic to separate files:builtins/bigint/operations.rs
forBigInt
operations.builtins/bigint/conversions.rs
forBigInt
conversions.builtins/bigint/equality.rs
forBigInt
equality checking.