Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Property accessor - executor] fix bracket accessing on non-objects types #469

Merged
merged 1 commit into from
Jun 10, 2020

Conversation

croraf
Copy link
Contributor

@croraf croraf commented Jun 9, 2020

Closes #210
I've added 4 tests, to test accessing properties on functions and strings with both bracket and dot notation.

@codecov
Copy link

codecov bot commented Jun 9, 2020

Codecov Report

Merging #469 into master will increase coverage by 0.05%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
+ Coverage   66.39%   66.44%   +0.05%     
==========================================
  Files         146      146              
  Lines        9350     9376      +26     
==========================================
+ Hits         6208     6230      +22     
- Misses       3142     3146       +4     
Impacted Files Coverage Δ
boa/src/exec/field/mod.rs 73.33% <60.00%> (-8.49%) ⬇️
boa/src/exec/tests.rs 100.00% <100.00%> (ø)
boa/src/builtins/value/conversions.rs 42.42% <0.00%> (-0.44%) ⬇️
boa/src/builtins/value/mod.rs 55.58% <0.00%> (-0.27%) ⬇️
boa/src/builtins/json/tests.rs 100.00% <0.00%> (ø)
boa/src/builtins/json/mod.rs 87.14% <0.00%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78934d...616f2f9. Read the comment docs.

@croraf croraf changed the title [Property accessor - executor] fix bracket accessing on non-objects [Property accessor - executor] fix bracket accessing on non-objects types Jun 9, 2020
@jasonwilliams jasonwilliams added this to the v0.9.0 milestone Jun 9, 2020
@HalidOdat HalidOdat added bug Something isn't working execution Issues or PRs related to code execution labels Jun 10, 2020
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the contribution :)

@Razican Razican merged commit ca80114 into boa-dev:master Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

builtinfun.length undefined
4 participants