TypeError when to_object is passed null or undefined

[zanayr]

This Pull Request fixes/closes #483.

It changes the following:

• Changed the to_object implementation to throw a TypeError when passed an undefined or null value.

Best,

[codecov]

Codecov Report

Merging #518 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #518      +/-   ##
==========================================
+ Coverage   68.06%   68.09%   +0.02%     
==========================================
  Files         169      169              
  Lines        9918     9925       +7     
==========================================
+ Hits         6751     6758       +7     
  Misses       3167     3167              

Impacted Files	Coverage Δ
boa/src/exec/mod.rs	66.91% <100.00%> (+0.12%)	⬆️
boa/src/exec/tests.rs	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f8498e...1607588. Read the comment docs.

[zanayr]

I think I did this correctly, not sure why I'm getting a large red rectangle and it failed that check. Not finding any useful information..

Please let me know if there is something i need to change/fix.

Best,

[Razican]

I think I did this correctly, not sure why I'm getting a large red rectangle and it failed that check. Not finding any useful information..

Please let me know if there is something i need to change/fix.

Best,

This check is related to the test coverage of the code. We should add a test that checks that this works as expected.

[zanayr]

Ok! I will fix that tonight.

[zanayr]

@Razican I didn't find an existing to_object test, so I worte this test:

#[test]
fn to_object() {
    let realm = Realm::create();
    let mut engine = Interpreter::new(realm);
    
    assert!(engine.to_object(&Value::undefined()).is_err());
    assert!(engine.to_object(&Value::null()).is_err());
}

My only question is where to put it? in the test.rs file in the src/exec directory?

[HalidOdat]

My only question is where to put it? in the test.rs file in the src/exec directory?

Yes. that is the best place.

For the test I think it's best if we test that it's an Object rather than a thrown Value, because the previous test will pass before the fix too, since we were throwing undefined

#[test]
fn to_object() {
    let realm = Realm::create();
    let mut engine = Interpreter::new(realm);
    
    assert!(engine.to_object(&Value::undefined()).unwrap_err().is_object());
    assert!(engine.to_object(&Value::null()).unwrap_err().is_object());
}

[zanayr]

I think i messed something up... 😅
There was a conflict and I thought I resolved it... but it seems I made things worse.